-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: declarative JS toolchain as code - via volta --- reduces dev env variations (v1) #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the main README.md the instruction / requirement to install volta
Thanks. @sidmohanty11
@Sing-Li please let me know if this is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this AFTER line 47. Also avoid putting a SPECIFIC node version into README.md, as this will require changes everytime after strapi upgrade.
In addition, we want to use this to enforce node / npm and other tool versions - for all distributed development team members -- and not just "node for strapi".
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Can you please check, if this line is descriptive enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please says "... only the appropriate version of nodeJS and npm to ensure ...."
@Sing-Li done 👍 , please check if I need to do some other changes. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll merge this after all the automated tests.
Please start on the "stub" simple/trivial auth component to ease the out-of-box dev experience.
@Sing-Li sure |
v14.18.3
LTS using volta, for using this, users must have volta installed. This can be achieved using this command -curl https://get.volta.sh | bash
/app/
has 0 vulnerability from 4 and/cms/
has 14 vulnerabilities from 17.nvmrc
file for managing node versions/node_modules/
and/package-lock.json
from rootPreview
voltafix.mp4