Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: declarative JS toolchain as code - via volta --- reduces dev env variations (v1) #154

Merged
merged 3 commits into from
May 22, 2022

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented May 21, 2022

  • Pinned v14.18.3 LTS using volta, for using this, users must have volta installed. This can be achieved using this command - curl https://get.volta.sh | bash
  • audited and updated packages as required, now /app/ has 0 vulnerability from 4 and /cms/ has 14 vulnerabilities from 17
  • Added .nvmrc file for managing node versions
  • deleted redundant /node_modules/ and /package-lock.json from root

Preview

voltafix.mp4

@Sing-Li Sing-Li changed the title chore: Clean up(v1) chore: declarative JS toolchain as code - via volta --- reduces dev env variations (v1) May 22, 2022
Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to the main README.md the instruction / requirement to install volta

Thanks. @sidmohanty11

@sidmohanty11
Copy link
Contributor Author

@Sing-Li please let me know if this is fine

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this AFTER line 47. Also avoid putting a SPECIFIC node version into README.md, as this will require changes everytime after strapi upgrade.

In addition, we want to use this to enforce node / npm and other tool versions - for all distributed development team members -- and not just "node for strapi".

Thanks.

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@sidmohanty11
Copy link
Contributor Author

@Sing-Li

Nodejs versioning is managed by volta. You can install it by running curl https://get.volta.sh | bash in your terminal. This is needed to ensure that Nodejs v14 and npm v6 are used for compatibility for all distributed development team members.

Can you please check, if this line is descriptive enough?

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please says "... only the appropriate version of nodeJS and npm to ensure ...."

@sidmohanty11
Copy link
Contributor Author

@Sing-Li done 👍 , please check if I need to do some other changes.

Thank you!

@sidmohanty11 sidmohanty11 requested a review from Sing-Li May 22, 2022 17:54
Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge this after all the automated tests.

Please start on the "stub" simple/trivial auth component to ease the out-of-box dev experience.

@Sing-Li Sing-Li merged commit d5b01dd into RocketChat:master May 22, 2022
@sidmohanty11
Copy link
Contributor Author

@Sing-Li sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants