-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Remove Typos in JSX, Add Unique Keys to props and Add id field in Forms #59
[FIX] Remove Typos in JSX, Add Unique Keys to props and Add id field in Forms #59
Conversation
What are the remaining 3 errors? Are they unfixable? |
@RonLek since it was your choice of component to use - do you think we should fork it and fix the problem? |
@samad-yar-khan please resolve the conflicts. We'll merge this after that. |
@Sing-Li , will surely do. I tried implement a hack to resolve the issue with the slick library, but didn't really work out. Apart from that I am not getting any other warnings from this branch. I will try to solve the issue one more time and update you on this thread. |
5c68b35
to
3b5d998
Compare
This pull request introduces 1 alert when merging 3b5d998 into e5d3c71 - view on LGTM.com new alerts:
|
forcing workflow run |
e13ed46
to
7b3daf2
Compare
@Sing-Li Resolved Errors and Rebased with the current master branch. It would be great if you could take a look 😄 |
Proposed changes (including videos or screenshots)
I added unique key props to cater to different environments. id for Strapii and _id for mongoDB.
Fixed Typos in JSX.
Added id in searchBox Toggle to avoid warning : Issue
Note : The only warning being displayed on console now are due to the issues persisting in the react-slick library. Reference
Issue(s)
Fixes : #58
Steps to test or reproduce
Mentioned in the Issue
Before :
2022-01-26.20-20-49_Trim.mp4
After :
2022-01-26.20-17-33_Trim.mp4