Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove Typos in JSX, Add Unique Keys to props and Add id field in Forms #59

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

samad-yar-khan
Copy link
Contributor

@samad-yar-khan samad-yar-khan commented Jan 26, 2022

Proposed changes (including videos or screenshots)

  • I added unique key props to cater to different environments. id for Strapii and _id for mongoDB.

  • Fixed Typos in JSX.

  • Added id in searchBox Toggle to avoid warning : Issue image

  • Note : The only warning being displayed on console now are due to the issues persisting in the react-slick library. Reference

Issue(s)

Fixes : #58

Steps to test or reproduce

Mentioned in the Issue

Before :

2022-01-26.20-20-49_Trim.mp4

After :

2022-01-26.20-17-33_Trim.mp4

@Sing-Li
Copy link
Member

Sing-Li commented Jan 26, 2022

What are the remaining 3 errors? Are they unfixable?

@samad-yar-khan
Copy link
Contributor Author

samad-yar-khan commented Jan 26, 2022

@Sing-Li Unfortunately, the other three errors are due to the issue in the react-slick module. It has been closed but it still hasn't been solved

@Sing-Li
Copy link
Member

Sing-Li commented Jan 27, 2022

@RonLek since it was your choice of component to use - do you think we should fork it and fix the problem?

@Sing-Li
Copy link
Member

Sing-Li commented Jan 28, 2022

@samad-yar-khan please resolve the conflicts. We'll merge this after that.

@samad-yar-khan
Copy link
Contributor Author

@samad-yar-khan please resolve the conflicts. We'll merge this after that.

@Sing-Li , will surely do. I tried implement a hack to resolve the issue with the slick library, but didn't really work out. Apart from that I am not getting any other warnings from this branch. I will try to solve the issue one more time and update you on this thread.

@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2022

This pull request introduces 1 alert when merging 3b5d998 into e5d3c71 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@debdutdeb
Copy link
Member

forcing workflow run

@debdutdeb debdutdeb closed this Jan 29, 2022
@debdutdeb debdutdeb reopened this Jan 29, 2022
@samad-yar-khan
Copy link
Contributor Author

@samad-yar-khan please resolve the conflicts. We'll merge this after that.

@Sing-Li Resolved Errors and Rebased with the current master branch. It would be great if you could take a look 😄

@debdutdeb debdutdeb merged commit 140f0ad into RocketChat:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Console Warning/Errors
3 participants