Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mainstage Speakers Conference Page #83

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented Feb 26, 2022

This is still work in progress,

  • Make infotiles component more generic
  • Above circular SVGs are needed to be added
  • On mobile screen, wrap it to one speaker card component not 2
  • Use strapi cms to retrieve data

Web

screencapture-localhost-3000-virtualconf-mainstage-2022-02-27-02_50_52

Mobile

screencapture-localhost-3000-virtualconf-mainstage-2022-02-27-02_51_26

@lgtm-com
Copy link

lgtm-com bot commented Feb 26, 2022

This pull request introduces 1 alert when merging 6f66db0 into 154b9b0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 27, 2022

This pull request introduces 1 alert when merging 0049396 into 154b9b0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sidmohanty11
Copy link
Contributor Author

Web View

screencapture-localhost-3000-virtualconf-mainstage-2022-02-27-20_27_45

Mobile View

screencapture-localhost-3000-virtualconf-mainstage-2022-02-27-20_28_04

And the data is fetched from strapi, it has a Speakers Component now which possess the mentioned fields:

  • id
  • name (of the speaker)
  • content (a small description of speaker)
  • imageUrl (PhotoUrl of the speaker)
  • live (which is a boolean, so that we can conditionally render the live button and provide the confHref)
  • ended (also a boolean, to disable out the speakers as described in the figma design)
  • confHref (conference link)

Strapi

Screenshot from 2022-02-27 20-30-32

@Sing-Li please check the model and suggest the changes

@sidmohanty11 sidmohanty11 changed the title wip: Mainstage Speakers Conference Page [NEW] Mainstage Speakers Conference Page Feb 27, 2022
app/pages/_app.js Outdated Show resolved Hide resolved
@Sing-Li
Copy link
Member

Sing-Li commented Feb 28, 2022

Please add an announcement or a banner (banner component?) to the home page and link to this conference. Please consult @demonicirfan if you need some minor design help here.

@sidmohanty11
Copy link
Contributor Author

Sure, let me consult with him with the design and I'll let you know

@Sing-Li
Copy link
Member

Sing-Li commented Mar 1, 2022

Thanks for the updates. This is a great foundation to build other parts of the virtual conference handling on. I will go ahead and merge it.

@Sing-Li Sing-Li merged commit 304ed53 into RocketChat:master Mar 1, 2022
@Sing-Li Sing-Li changed the title [NEW] Mainstage Speakers Conference Page Add Mainstage Speakers Conference Page Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants