-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add form components "creator kit" #84
Conversation
This pull request introduces 1 alert when merging 59fa5cd into 154b9b0 - view on LGTM.com new alerts:
|
Thanks @Dnouv ! Cool. The current workflow of RC4Community has no interactive "design time" behaviours. Since your code here entails only interactive design-time behaviours, it is best to have it running standalone as a separate tool. It can generate the actual JSX , or the source code of the react component to display/manage the form directly. Or a better solution is if this tool will write the "form description data" to strapi, and then have a set of custom ReactJS tag that can render this form during build time by fetching the "form description data". |
This pull request introduces 1 alert when merging 2ff0573 into bac5553 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our conversation on Rocket.Chat @Dnouv
-
please place your creation tool as an INDEPENDENT TOOL under
/contrib/formcreator
directory, it should be a standalone 100% independent nodeJS based tool - and not part of RC4Community framework -
please create components under
components
directory that will be re-usable and renders the form for the community builder -
please create a demo page under
pages/formdemo
that shows FOUR or FIVE instances of your forms components - displaying FOUR or FIVE forms simultaneously on one single page (nothing else) ... this will illustrate to everyone that your component is easily re-usable
Other than the above, please do not add any additional source files that may alter the structure of the project
This pull request introduces 2 alerts when merging d3dc89f into bac5553 - view on LGTM.com new alerts:
|
d3dc89f
to
c5712bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredibly awesome work @Dnouv 🙏
Please remove package-lock.json from the PR (perhaps add it your .gitignore) and it will be good enough for initial merge-down.
Thanks!
Thank you so much for the feedback @Sing-Li . |
This PR introduces a form component.
Here are some preview images.
Thank you!
Note: Please do not merge. WIP