Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add form components "creator kit" #84

Merged
merged 15 commits into from
Mar 12, 2022

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Feb 28, 2022

This PR introduces a form component.
Here are some preview images.


Thank you!

Note: Please do not merge. WIP

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2022

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Feb 28, 2022

This pull request introduces 1 alert when merging 59fa5cd into 154b9b0 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Sing-Li
Copy link
Member

Sing-Li commented Feb 28, 2022

Thanks @Dnouv ! Cool.

The current workflow of RC4Community has no interactive "design time" behaviours. Since your code here entails only interactive design-time behaviours, it is best to have it running standalone as a separate tool.

It can generate the actual JSX , or the source code of the react component to display/manage the form directly.

Or a better solution is if this tool will write the "form description data" to strapi, and then have a set of custom ReactJS tag that can render this form during build time by fetching the "form description data".

@lgtm-com
Copy link

lgtm-com bot commented Mar 2, 2022

This pull request introduces 1 alert when merging 2ff0573 into bac5553 - view on LGTM.com

new alerts:

  • 1 for Off-by-one comparison against length

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our conversation on Rocket.Chat @Dnouv

  1. please place your creation tool as an INDEPENDENT TOOL under /contrib/formcreator directory, it should be a standalone 100% independent nodeJS based tool - and not part of RC4Community framework

  2. please create components under components directory that will be re-usable and renders the form for the community builder

  3. please create a demo page under pages/formdemo that shows FOUR or FIVE instances of your forms components - displaying FOUR or FIVE forms simultaneously on one single page (nothing else) ... this will illustrate to everyone that your component is easily re-usable

Other than the above, please do not add any additional source files that may alter the structure of the project

@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2022

This pull request introduces 2 alerts when merging d3dc89f into bac5553 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

app/pages/forms/formdemo.js Outdated Show resolved Hide resolved
@Dnouv
Copy link
Member Author

Dnouv commented Mar 12, 2022

A new demo page is added with a few preview forms, here is a screenshot of the page

Suggestions are most welcomed. Thank you!

Copy link
Member

@Sing-Li Sing-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredibly awesome work @Dnouv 🙏

Please remove package-lock.json from the PR (perhaps add it your .gitignore) and it will be good enough for initial merge-down.

Thanks!

@Sing-Li Sing-Li changed the title [NEW]*[WIP] Add form component [NEW]*[WIP] Add form components "creators kit" Mar 12, 2022
@Sing-Li Sing-Li changed the title [NEW]*[WIP] Add form components "creators kit" [NEW]*[WIP] Add form components "creator kit" Mar 12, 2022
@Dnouv
Copy link
Member Author

Dnouv commented Mar 12, 2022

Thank you so much for the feedback @Sing-Li .
I've reverted the changes of package-lock.json and pushed the changes.
Thank you!

@Sing-Li Sing-Li changed the title [NEW]*[WIP] Add form components "creator kit" [NEW] Add form components "creator kit" Mar 12, 2022
@Sing-Li Sing-Li merged commit 508b2b7 into RocketChat:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants