-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] GitHub Component Kit #91
[NEW] GitHub Component Kit #91
Conversation
This pull request introduces 5 alerts when merging 2f888d7 into 50f7da2 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 7831f14 into 50f7da2 - view on LGTM.com new alerts:
|
@Sing-Li I have made some changes and removed the unnecessary code, it would be great if you could review the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good clean up work, congrats.
However, you added back package.json and some index.js modifications
Please remove package.json and the index.js modifications. Take a look at other PRs and see how they use a demo page under pages
to demonstrate their component. Thanks.
5907926
to
f2e3717
Compare
@Sing-Li I have made the requested changed :
2022-03-18.18-29-21.mp4 |
Issues
Mentioned in the issue #90
Proposed changes (including videos or screenshots)
githubKit()
function.<Github ... >
tag which can be used to fetch different components of the kit depending on props/parameters.<Github type={'contributors'} githubData={props.githubData} />
githubKitData(owner ,name ,[..needs])
function which can fetch relevant data based on the components we wish to use on a particular page.