Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Better RU localization #1591

Closed
wants to merge 14 commits into from

Conversation

twi123
Copy link

@twi123 twi123 commented Aug 9, 2018

@RocketChat/android

  1. Fix missing "Done" button (now it can be localized)
  2. More correct RU localization

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2018

CLA assistant check
All committers have signed the CLA.

@luciofm
Copy link
Contributor

luciofm commented Aug 9, 2018

@twi123 thanks for the PR. You need to rebase your PR against develop branch and sign the CLA

@twi123
Copy link
Author

twi123 commented Aug 9, 2018

I've signed CLA
PR rebased to develop

@luciofm luciofm changed the base branch from master to develop August 9, 2018 15:10
@luciofm
Copy link
Contributor

luciofm commented Aug 9, 2018

@twi123 can you please add the string done in english to other languages with a TODO comment, like:
<string name="dialog_button_done">Done</string> <!-- TODO Add translation -->

That way your PR will pass on our automated checks.

@luciofm luciofm added this to In Progress in Cycle 08: 08/05 ~ 08/27 via automation Aug 9, 2018
@luciofm luciofm added this to the 2.6.0 milestone Aug 9, 2018
@luciofm luciofm changed the base branch from develop to beta August 10, 2018 11:51
@luciofm luciofm changed the base branch from beta to develop August 10, 2018 11:51
@luciofm
Copy link
Contributor

luciofm commented Aug 10, 2018

Thanks @twi123, did a rebase and squash and merge manually. Thank you again

@luciofm luciofm closed this Aug 10, 2018
Cycle 08: 08/05 ~ 08/27 automation moved this from In Progress to Done Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants