Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments on CloudWorkspace #386

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

d-gubert
Copy link
Member

What? ⛵

Improve comments on the CloudWorkspace related classes/interfaces.

Why? 🤔

Links 🌎

PS 👀

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #386 (4875e4f) into beta (97707f2) will increase coverage by 0.55%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta     #386      +/-   ##
==========================================
+ Coverage   49.59%   50.14%   +0.55%     
==========================================
  Files         102      110       +8     
  Lines        3176     3350     +174     
  Branches      468      469       +1     
==========================================
+ Hits         1575     1680     +105     
- Misses       1601     1670      +69     
Impacted Files Coverage Δ
src/server/managers/AppPermissionManager.ts 20.00% <0.00%> (ø)
src/server/permissions/checkers/AppCloudBridge.ts 33.33% <0.00%> (ø)
src/server/compiler/modules/net.ts 50.00% <0.00%> (-50.00%) ⬇️
...c/server/permissions/checkers/AppInternalBridge.ts 20.00% <0.00%> (-30.00%) ⬇️
...issions/checkers/AppEnvironmentalVariableBridge.ts 30.76% <0.00%> (-29.24%) ⬇️
src/server/permissions/checkers/AppApisBridge.ts 36.36% <0.00%> (-26.14%) ⬇️
...ver/permissions/checkers/AppUiInteractionBridge.ts 44.44% <0.00%> (-22.23%) ⬇️
...server/permissions/checkers/AppActivationBridge.ts 11.11% <0.00%> (-22.23%) ⬇️
src/server/permissions/checkers/AppUploadBridge.ts 25.00% <0.00%> (-21.16%) ⬇️
.../server/permissions/checkers/AppSchedulerBridge.ts 25.00% <0.00%> (-21.16%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97707f2...4875e4f. Read the comment docs.

Copy link
Contributor

@thassiov thassiov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thassiov thassiov merged commit cb910c2 into beta Feb 26, 2021
@d-gubert d-gubert deleted the regression/cloud-workspace branch March 4, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants