[NEW] Add possibility to set room closer to LivechatUpdater.closeRoom

[cuonghuunguyen]

What? ⛵

• Add an optional param named closer into LivechatUpdater.closeRoom so that we can close the room with the correct closer.
  closes Possibility to set room closer when closing LiveChat Rooms #373

Why? 🤔

When closing the room with the Apps, the room closer and the close room message sender will always be set to the visitor. This is not a correct behavior because the visitor does not perform that function.
This is not a very clean approach, we actually should pass something like closeData which contains all the needed data for Rocket.Chat close room function, but to avoid breaking change we can accept this approach right now

Links 🌎

Rocket.Chat issue: RocketChat/Rocket.Chat#21025

PS 👀

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #391 (7cd690f) into alpha (f1c071d) will increase coverage by 1.23%.
The diff coverage is 100.00%.

❗ Current head 7cd690f differs from pull request most recent head fe47531. Consider uploading reports for the commit fe47531 to get more accurate results

@@            Coverage Diff             @@
##            alpha     #391      +/-   ##
==========================================
+ Coverage   48.67%   49.91%   +1.23%     
==========================================
  Files         103      110       +7     
  Lines        3244     3370     +126     
  Branches      476      473       -3     
==========================================
+ Hits         1579     1682     +103     
- Misses       1665     1688      +23     

Impacted Files	Coverage Δ
src/server/accessors/LivechatUpdater.ts	44.44% <100.00%> (+22.22%)	⬆️
src/server/compiler/modules/net.ts	50.00% <0.00%> (-50.00%)	⬇️
...c/server/permissions/checkers/AppInternalBridge.ts	20.00% <0.00%> (-30.00%)	⬇️
...issions/checkers/AppEnvironmentalVariableBridge.ts	30.76% <0.00%> (-29.24%)	⬇️
src/server/permissions/checkers/AppApisBridge.ts	36.36% <0.00%> (-26.14%)	⬇️
...ver/permissions/checkers/AppUiInteractionBridge.ts	44.44% <0.00%> (-22.23%)	⬇️
...server/permissions/checkers/AppActivationBridge.ts	11.11% <0.00%> (-22.23%)	⬇️
src/server/permissions/checkers/AppUploadBridge.ts	25.00% <0.00%> (-21.16%)	⬇️
.../server/permissions/checkers/AppSchedulerBridge.ts	25.00% <0.00%> (-21.16%)	⬇️
src/server/errors/PermissionDeniedError.ts	14.28% <0.00%> (-19.05%)	⬇️
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b574248...fe47531. Read the comment docs.

[lucassartor]

Hi @meomay503! Can you share the app you've made to test the functionality? Thanks 🤗

[cuonghuunguyen]

Hi, thanks for having a look at this PR.
clean-all-livechat-room_0.0.1.zip
I've created a simple app to test this. It basically clean all opening livechat rooms by the closer is rocket.cat by the slash command /clean-livechat
Pls remember to link the correct version for Apps-Engine and also Rocket.Chat.

[cuonghuunguyen]

Do u have any updates on this?

[graywolf336]

@cuonghuunguyen any chance you can update this PR to resolve the conflicts? Once you do and everything is ready to go, I'll internally push this PR forward and try to get it (and all the connected pieces) merged ASAP. My apologies that his has not received any attention. I work on the marketplace now and was going through your Clean Livechat app to review it and seen your reference to this PR. As a result of that, that's why I am more active in this repo :)

[cuonghuunguyen]

ok, I'll update this one ASAP

[cuonghuunguyen]

hi @graywolf336, I updated the PRs

[graywolf336]

Just to double check, this is backwards compatible, right? So if I install an App that uses an old apps engine, will it still work even if the rocket.chat server has this version?

[cuonghuunguyen]

It still work, the new closer field is optional

[d-gubert]

Thank you for the contribution!