-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW][APPS] Possibility to set room closer via Apps LivechatBridge.closeRoom #21025
[NEW][APPS] Possibility to set room closer via Apps LivechatBridge.closeRoom #21025
Conversation
2b259e6
to
5f17c3f
Compare
42b6d92
to
0c1612f
Compare
232daac
to
0fbb310
Compare
0fbb310
to
57fbc24
Compare
57fbc24
to
8957808
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!!
This was supposed to be in the PR referring to this in the Apps-Engine repo lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For realz now, thank you for the contribution!! :D
Proposed changes (including videos or screenshots)
Add an optional param named
closer
intoLivechatBridge.closeRoom
so that it will be possible to close the room and send a close room message with the correct room closer.If the param is not passed, use the room visitor as the room closer.
Issue(s)
closes RocketChat/Rocket.Chat.Apps-engine#373
Apps-Engine's PR: RocketChat/Rocket.Chat.Apps-engine#391
Steps to test or reproduce
Further comments