[FIX] alternate method name in app.getAppUsername() deprecation notice #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Debdut Chakraborty debdut.chakraborty@rocket.chat
What? ⛵
Changed deprecation notice text for
app.getAppUsername()
Why? 🤔
The correct alternative is
read.getUserReader().getAppUser()
notread.getAppUser()
Rocket.Chat.Apps-engine/src/definition/accessors/IRead.ts
Line 30 in ccc46d0
Rocket.Chat.Apps-engine/src/definition/accessors/IUserRead.ts
Lines 7 to 16 in ccc46d0
Links 🌎
PS 👀