Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] alternate method name in app.getAppUsername() deprecation notice #452

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Nov 6, 2021

Signed-off-by: Debdut Chakraborty debdut.chakraborty@rocket.chat

What? ⛵

Changed deprecation notice text for app.getAppUsername()

Why? 🤔

The correct alternative is read.getUserReader().getAppUser() not read.getAppUser()

export interface IUserRead {
getById(id: string): Promise<IUser>;
getByUsername(username: string): Promise<IUser>;
/**
* Gets the app user of this app.
*/
getAppUser(appId?: string): Promise<IUser | undefined>;
}

Links 🌎

PS 👀

Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@d-gubert d-gubert merged commit a81687b into alpha Nov 8, 2021
@graywolf336 graywolf336 deleted the fix-app.getAppUsername-deprecation-notice branch November 8, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants