New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Update IModifyCreator to expose IUserBuilder to enable user creation #536
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I tested it on my local and it works fine.
One suggestion when you are making "dummy users", mark them as bots. Some customers are limited in the amount of users they can have in their environments and are charged per seats, so make sure you're not accidently increasing their billing. |
While looking into this, we need to take into account several factors and figure out answers to some questions: Some Rocket.Chat instances are billed per user in their system, apps shouldn't be responsible for causing huge biling. Currently users which are marked as federated are excluded from billing, so is that the route to go? Do we limit what type of users the apps can create? Do we automatically delete users created by the app when it is uninstalled? |
About the billed seats, we had a discussion and decided to allow to create only bot users. (It may change if necessary) We'll implement the feature to delete all users when you uninstall the app. Probably, we'll use the appId to find all users created by the app and delete them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What? ⛵
Updated IModifyCreator to expose APIs to create & finish IUserBuilder to enable user creation for Roket.Chat Apps.
Why? 🤔
I'm a contributor for GSOC 2022 and currently working on a Rocket.Chat App to enable interop between Rocket.Chat and Microsoft Teams. The core approach for the interop is we create "dummy users" in Rocket.Chat. Each "dummy user" represents a real Teams user in Rocket.Chat world. Rocket.Chat users just need to send message to "dummy user" and the App will do the message delivery to Teams in order to build a smooth interop experience.
With this "dummy user" approach, we need this API to enable user creation for Apps.
Links 🌎
Document for "dummy user" approach
PS 👀
AD-117