Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Unread count on header back button #1083

Conversation

IlarionHalushka
Copy link
Contributor

@IlarionHalushka IlarionHalushka commented Jul 29, 2019

@RocketChat/ReactNative
Closes #778

This PR aims to add an "unread messages counter" inside of RoomView next to the header back button.

Screenshots:
Screen Shot 2019-08-07 at 10 53 46 PM
Screen Shot 2019-08-07 at 10 54 20 PM

@IlarionHalushka IlarionHalushka changed the title [WIP] implement unread count on header back button [FEATURE] implement unread count on header back button Jul 30, 2019
app/views/RoomView/index.js Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
app/views/RoomView/index.js Outdated Show resolved Hide resolved
app/views/RoomView/index.js Outdated Show resolved Hide resolved
@djorkaeffalexandre
Copy link
Collaborator

@IlarionHalushka can you add Android Screenshots and update iOS Screenshots?

@djorkaeffalexandre
Copy link
Collaborator

@IlarionHalushka I think we not need back string:

Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

app/views/RoomView/Header/Header.js Outdated Show resolved Hide resolved
app/views/RoomView/index.js Outdated Show resolved Hide resolved
@diegolmello diegolmello changed the title [FEATURE] implement unread count on header back button [NEW] Unread count on header back button Aug 22, 2019
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegolmello diegolmello merged commit 8309c45 into RocketChat:develop Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Show unread count in room's back button
3 participants