-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Unread count on header back button #1083
Merged
diegolmello
merged 11 commits into
RocketChat:develop
from
IlarionHalushka:feat-unread-count-on-header-back-button
Aug 22, 2019
Merged
[NEW] Unread count on header back button #1083
diegolmello
merged 11 commits into
RocketChat:develop
from
IlarionHalushka:feat-unread-count-on-header-back-button
Aug 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlarionHalushka
changed the title
[WIP] implement unread count on header back button
[FEATURE] implement unread count on header back button
Jul 30, 2019
IlarionHalushka
added
👀 needs review
👍 improvement
🎉 feature
and removed
👍 improvement
labels
Jul 30, 2019
djorkaeffalexandre
requested changes
Jul 31, 2019
diegolmello
requested changes
Aug 7, 2019
@IlarionHalushka can you add Android Screenshots and update iOS Screenshots? |
@IlarionHalushka I think we not need |
djorkaeffalexandre
approved these changes
Aug 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diegolmello
requested changes
Aug 19, 2019
…k-button' into feat-unread-count-on-header-back-button
diegolmello
changed the title
[FEATURE] implement unread count on header back button
[NEW] Unread count on header back button
Aug 22, 2019
diegolmello
approved these changes
Aug 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/ReactNative
Closes #778
This PR aims to add an "unread messages counter" inside of RoomView next to the header back button.
Screenshots: