Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Messages overlapping and emoji keyboard not opening #2670

Merged
merged 8 commits into from
Dec 1, 2020

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Nov 24, 2020

Proposed changes

This PR aims to fix 2 issues.

  • Messages overlapping each other on Android
  • Emoji keyboard not opening properly on Android

Currently, we use patches for react-native-keyboard-tracking-view and react-native-keyboard-input on our Messagebox. Both of them are from Wix, but they moved them both to their new UI lib repo: https://github.com/wix/react-native-ui-lib

Issue(s)

Closes #2633

Depends on:
RocketChat/react-native-jitsi-meet#6
RocketChat/react-native-ui-lib#1

How to test or reproduce

Messages overlapping each other on Android

Follow steps described on #2633

Emoji keyboard not opening properly on Android

  • Nav to a thread
  • Nav back to main channel
  • Open emoji keyboard
  • prior to this PR, emoji keyboard wouldn't open

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title [FIX] Messages overlapping [FIX] Messages overlapping and emoji keyboard not opening Nov 30, 2020
Copy link
Collaborator

@djorkaeffalexandre djorkaeffalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	ios/Pods/Pods.xcodeproj/project.pbxproj
#	ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService.debug.xcconfig
#	ios/Pods/Target Support Files/Pods-NotificationService/Pods-NotificationService.release.xcconfig
#	ios/Pods/Target Support Files/Pods-RocketChatRN/Pods-RocketChatRN.debug.xcconfig
#	ios/Pods/Target Support Files/Pods-RocketChatRN/Pods-RocketChatRN.release.xcconfig
#	ios/Pods/Target Support Files/Pods-ShareRocketChatRN/Pods-ShareRocketChatRN.debug.xcconfig
#	ios/Pods/Target Support Files/Pods-ShareRocketChatRN/Pods-ShareRocketChatRN.release.xcconfig
#	yarn.lock
@diegolmello diegolmello merged commit 7b4be8b into develop Dec 1, 2020
@diegolmello diegolmello deleted the fix.messages-overlapping branch December 1, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages overlap in thread
2 participants