Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send native calculated keyboard and tracking view height to TS #5514

Merged
merged 2 commits into from
Jan 26, 2024
Merged

feat: Send native calculated keyboard and tracking view height to TS #5514

merged 2 commits into from
Jan 26, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Jan 25, 2024 •
edited by jira bot

Proposed changes

This change makes the keyboardHeight and trackingViewHeight to react faster than before.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-461

@diegolmello diegolmello merged commit cedd0b9 into develop Jan 26, 2024
3 of 8 checks passed
@diegolmello diegolmello deleted the feat.tracking-view-height branch January 26, 2024 20:40
diegolmello added a commit that referenced this pull request Jan 29, 2024
@diegolmello
Revert "feat: Send native calculated keyboard and tracking view heigh…
9092a0e 
…t to TS (#5514)"

This reverts commit cedd0b9.
@diegolmello diegolmello mentioned this pull request Jan 29, 2024
Merged
10 tasks
diegolmello added a commit that referenced this pull request Jan 29, 2024
@diegolmello
Revert "feat: Send native calculated keyboard and tracking view heigh…
9bb6765 
…t to TS (#5514)"

This reverts commit cedd0b9.
diegolmello added a commit that referenced this pull request Jan 31, 2024
@diegolmello
feat: better composer height calculation (#5523)
7b73eac 
* Revert "feat: Send native calculated keyboard and tracking view height to TS (#5514)"

This reverts commit cedd0b9.

* better height calculation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GleidsonDaniel GleidsonDaniel GleidsonDaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diegolmello @GleidsonDaniel