Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better composer height calculation #5523

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Jan 29, 2024

Proposed changes

This is an improved version of #5514

KeyboardAccessoryView provides onHeightChanged, which makes use of onLayout based on the actual native component.
There's no need to patch react-native-ui-lib or to wrap the composer in another View.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-478

@diegolmello diegolmello merged commit 7b73eac into develop Jan 31, 2024
14 of 18 checks passed
@diegolmello diegolmello deleted the feat.better-height-calculation branch January 31, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants