feat: Allows multiple emails and phone numbers in edit contact info #23269
dougfabrisci.yml
on: pull_request
⚙️ Variables Setup
6s
Matrix: 🔎 Code Check / code-check
Matrix: 🚢 Build Docker Images for Testing
Matrix: 🔨 Test API (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test API (CE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (EE) / test
Waiting for pending jobs
Matrix: 🔨 Test UI (CE) / test
Waiting for pending jobs
Matrix: 🚢 Build Docker Images for Production
Matrix: 🚀 Publish Docker Image (main)
Matrix: 🚀 Publish Docker Image (services)
🚀 Notify external services
0s
trigger-dependent-workflows
0s
Update Version Durability
/
update-versions
Annotations
17 errors and 18 warnings
|
🔎 Code Check / Code Lint
@rocket.chat/meteor#lint: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-8fb4d7cd/yarn run lint exited (1)
|
|
|
|
🔎 Code Check / Code Lint:
apps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsx#L208
'phoneField' is assigned a value but never used
|
|
🔎 Code Check / Code Lint:
apps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsx#L256
Replace `{t('Add_email')}` with `⏎↹↹↹↹↹↹{t('Add_email')}⏎↹↹↹↹↹`
|
|
🔎 Code Check / Code Lint:
apps/meteor/client/views/omnichannel/contactInfo/EditContactInfo.tsx#L275
Replace `{t('Add_phone')}` with `⏎↹↹↹↹↹↹{t('Add_phone')}⏎↹↹↹↹↹`
|
|
🔎 Code Check / Code Lint
Process completed with exit code 1.
|
|
🔎 Code Check / TypeScript
Property 'email' does not exist on type 'ContactFormData'. Did you mean 'emails'?
|
|
🔎 Code Check / TypeScript
Property 'phone' does not exist on type 'ContactFormData'. Did you mean 'phones'?
|
|
🔎 Code Check / TypeScript
Argument of type '"email"' is not assignable to parameter of type '"username" | "token" | "name" | "customFields" | "emails" | `emails.${number}.address` | "root" | `root.${string}` | "phones" | `customFields.${string}` | `emails.${number}` | `phones.${number}` | `phones.${number}.phoneNumber`'.
|
|
🔎 Code Check / TypeScript
Argument of type '"phone"' is not assignable to parameter of type '"username" | "token" | "name" | "customFields" | "emails" | `emails.${number}.address` | "root" | `root.${string}` | "phones" | `customFields.${string}` | `emails.${number}` | `phones.${number}` | `phones.${number}.phoneNumber`'.
|
|
🔎 Code Check / TypeScript
Type 'ContactFormData' has no properties in common with type '{ phone?: string | undefined; email?: string | undefined; }'.
|
|
🔎 Code Check / TypeScript
@rocket.chat/meteor#typecheck: command (/home/runner/work/Rocket.Chat/Rocket.Chat/apps/meteor) /tmp/xfs-60e633af/yarn run typecheck exited (2)
|
|
🔎 Code Check / TypeScript
Property 'phone' does not exist on type 'ContactFormData'.
|
|
🔎 Code Check / TypeScript
Property 'email' does not exist on type 'ContactFormData'.
|
|
🔎 Code Check / TypeScript
'phoneField' is declared but its value is never read.
|
|
🔎 Code Check / TypeScript
Process completed with exit code 2.
|
|
✅ Tests Done
Process completed with exit code 1.
|
|
📦 Build Packages
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3, actions/setup-node@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔨 Test Unit / Unit Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3, actions/setup-node@v3.7.0, codecov/codecov-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
📦 Meteor Build - coverage
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3, actions/setup-node@v3.7.0, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔎 Code Check / Code Lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3, actions/setup-node@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔎 Code Check / Code Lint:
packages/fuselage-ui-kit/jest.setup.ts#L4
Do not use "@ts-ignore" because it alters compilation errors
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/lib/debug.js#L83
Consider using the native Array.prototype.forEach() or Object.entries().forEach()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/lib/notifyListener.ts#L369
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/lib/notifyListener.ts#L373
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/oauth/oauth.js#L42
Consider using the native Array.prototype.includes()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/lib/server/startup/rateLimiter.js#L65
Consider using the native Array.prototype.forEach() or Object.entries().forEach()
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/markdown/lib/hljs.js#L10
Async arrow function has a complexity of 173. Maximum allowed is 31
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts#L81
Static async method 'insertOrUpdateSAMLUser' has a complexity of 33. Maximum allowed is 31
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/reactions/client/init.ts#L32
Forbidden non-null assertion
|
|
🔎 Code Check / Code Lint:
apps/meteor/app/threads/client/messageAction/replyInThread.ts#L24
Forbidden non-null assertion
|
|
🚢 Build Docker Images for Testing (official)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: docker/login-action@v2, actions/download-artifact@v3, actions/cache@v3, actions/setup-node@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🔎 Code Check / TypeScript
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/cache@v3, actions/setup-node@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
🚢 Build Docker Images for Testing (alpine)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: docker/login-action@v2, actions/download-artifact@v3, actions/cache@v3, actions/setup-node@v3.7.0. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "build".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
build
|
362 MB |
|