fix: Unnecessary username validation on account profile form (#30677)

RocketChat · Oct 19, 2023 · 93a0859 · 93a0859
1 parent 79f6388
commit 93a0859
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.changeset/empty-files-know.md b/.changeset/empty-files-know.md
@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fix unnecessary username validation on accounts profile form
diff --git a/apps/meteor/client/views/account/profile/AccountProfileForm.tsx b/apps/meteor/client/views/account/profile/AccountProfileForm.tsx
@@ -66,6 +66,7 @@ const AccountProfileForm = (props: AllHTMLAttributes<HTMLFormElement>): ReactEle
 	const { email, avatar, username } = watch();
 
 	const previousEmail = user ? getUserEmailAddress(user) : '';
+	const previousUsername = user?.username || '';
 	const isUserVerified = user?.emails?.[0]?.verified ?? false;
 
 	const mutateConfirmationEmail = useMutation({
@@ -87,6 +88,10 @@ const AccountProfileForm = (props: AllHTMLAttributes<HTMLFormElement>): ReactEle
 			return;
 		}
 
+		if (username === previousUsername) {
+			return;
+		}
+
 		if (!namesRegex.test(username)) {
 			return t('error-invalid-username');
 		}