Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unnecessary username validation on account profile form #30677

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Oct 18, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  • Don't allow users to change username, turn off "Allow change of username" setting.
  • Open Account profile form
  • Try to update any form value
  • Can't save form as it always tries to validate username and fails since setting is off

Further comments

SUP-377

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 2a9b49b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review October 18, 2023 17:40
@yash-rajpal yash-rajpal requested a review from a team as a code owner October 18, 2023 17:40
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #30677 (2a9b49b) into develop (79f6388) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30677      +/-   ##
===========================================
- Coverage    51.19%   51.08%   -0.12%     
===========================================
  Files          811      809       -2     
  Lines        15059    15158      +99     
  Branches      2750     2812      +62     
===========================================
+ Hits          7709     7743      +34     
- Misses        6940     6975      +35     
- Partials       410      440      +30     
Flag Coverage Δ
e2e 48.41% <ø> (-0.09%) ⬇️
unit 64.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 19, 2023
@scuciatto scuciatto added this to the 6.4.3 milestone Oct 19, 2023
@kodiakhq kodiakhq bot merged commit 93a0859 into develop Oct 19, 2023
44 checks passed
@kodiakhq kodiakhq bot deleted the profile-form-username-validation branch October 19, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants