Skip to content

Commit

Permalink
[IMPROVE] Remove global Blaze helpers (#15414)
Browse files Browse the repository at this point in the history
* Remove unused not helper

* Move escapeCSsUrl helper to uploadedFilesList template
  • Loading branch information
tassoevan authored and ggazzo committed Sep 19, 2019
1 parent 968fbd9 commit d7724b2
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 13 deletions.
6 changes: 3 additions & 3 deletions app/integrations/client/views/integrationsOutgoing.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
<section class="page-container page-home page-static page-settings">
{{#header sectionName=pageTitle buttons=true}}
<div class="rc-header__section-button">
<button class="rc-button rc-button--secondary history" disabled="{{not showHistoryButton}}">{{_ "History"}}</button>
<button class="rc-button rc-button--cancel delete" disabled="{{not canDelete}}"><span>{{_ "Delete"}}</span></button>
<button class="rc-button rc-button--primary save" disabled="{{not hasTypeSelected}}"><span>{{_ "Save_changes"}}</span></button>
<button class="rc-button rc-button--secondary history" disabled="{{$not showHistoryButton}}">{{_ "History"}}</button>
<button class="rc-button rc-button--cancel delete" disabled="{{$not canDelete}}"><span>{{_ "Delete"}}</span></button>
<button class="rc-button rc-button--primary save" disabled="{{$not hasTypeSelected}}"><span>{{_ "Save_changes"}}</span></button>
</div>
{{/header}}

Expand Down
2 changes: 1 addition & 1 deletion app/ui-admin/client/admin.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{{#if hasChanges}}
<button class="rc-button rc-button--cancel discard"><span>{{_ "Cancel"}}</span></button>
{{/if}}
<button class="rc-button rc-button--primary save" disabled="{{not hasChanges}}"><span>{{_ "Save_changes"}}</span></button>
<button class="rc-button rc-button--primary save" disabled="{{$not hasChanges}}"><span>{{_ "Save_changes"}}</span></button>
{{#if $eq _id 'OAuth'}}
<button class="rc-button rc-button--secondary refresh-oauth"><span>{{_ "Refresh_oauth_services"}}</span></button>
<button class="rc-button rc-button--secondary add-custom-oauth"><span>{{_ "Add_custom_oauth"}}</span></button>
Expand Down
2 changes: 1 addition & 1 deletion app/ui-admin/client/users/adminUsers.html
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
</div>
</td>
<td width="20%">
<div class="rc-table-wrapper">{{#if not active}}{{_"deactivated"}}{{else}}{{status}}{{/if}}</div>
<div class="rc-table-wrapper">{{#if $not active}}{{_"deactivated"}}{{else}}{{status}}{{/if}}</div>
</td>
</tr>
{{else}} {{# with searchText}}
Expand Down
3 changes: 3 additions & 0 deletions app/ui-flextab/client/tabs/uploadedFilesList.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ Template.uploadedFilesList.helpers({
return getURL(this.url);
}
},

escapeCssUrl: (url) => url.replace(/(['"])/g, '\\$1'),

limit() {
return Template.instance().state.get('limit');
},
Expand Down
3 changes: 0 additions & 3 deletions client/templateHelpers/escapeCssUrl.js

This file was deleted.

2 changes: 0 additions & 2 deletions client/templateHelpers/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
import './escapeCssUrl';
import './log';
import './not';
import './pathFor';
3 changes: 0 additions & 3 deletions client/templateHelpers/not.js

This file was deleted.

0 comments on commit d7724b2

Please sign in to comment.