Merge pull request #10673 from saplla/optional-s3-credentials

[NEW] Make supplying an AWS access key and secret optional for S3 uploads
RocketChat · Jun 4, 2018 · e18cc89 · e18cc89
2 parents dc21a44 + a6c4bf3
commit e18cc89
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/packages/rocketchat-file-upload/server/config/AmazonS3.js b/packages/rocketchat-file-upload/server/config/AmazonS3.js
@@ -69,14 +69,12 @@ const configure = _.debounce(function() {
 	// const CDN = RocketChat.settings.get('FileUpload_S3_CDN');
 	const BucketURL = RocketChat.settings.get('FileUpload_S3_BucketURL');
 
-	if (!Bucket || !AWSAccessKeyId || !AWSSecretAccessKey) {
+	if (!Bucket) {
 		return;
 	}
 
 	const config = {
 		connection: {
-			accessKeyId: AWSAccessKeyId,
-			secretAccessKey: AWSSecretAccessKey,
 			signatureVersion: SignatureVersion,
 			s3ForcePathStyle: ForcePathStyle,
 			params: {
@@ -88,6 +86,14 @@ const configure = _.debounce(function() {
 		URLExpiryTimeSpan
 	};
 
+	if (AWSAccessKeyId) {
+		config.connection.accessKeyId = AWSAccessKeyId;
+	}
+
+	if (AWSSecretAccessKey) {
+		config.connection.secretAccessKey = AWSSecretAccessKey;
+	}
+
 	if (BucketURL) {
 		config.connection.endpoint = BucketURL;
 	}