Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Make supplying an AWS access key and secret optional for S3 uploads #10673

Merged
merged 5 commits into from
Jun 4, 2018

Conversation

saplla
Copy link
Contributor

@saplla saplla commented May 4, 2018

Closes #9098

PR for docs update: https://github.com/RocketChat/docs/pull/730

If no AWS access keys are supplied, the AWS SDK will try to pull them from various places such as IAM roles. This PR removes the hard requirement that credentials are supplied to support using IAM roles, etc.

@graywolf336 graywolf336 added this to the 0.65.0 milestone May 15, 2018
@engelgabriel engelgabriel merged commit e18cc89 into RocketChat:develop Jun 4, 2018
@engelgabriel engelgabriel added this to Desireable in June/2018 via automation Jun 4, 2018
@engelgabriel engelgabriel modified the milestones: 0.65.0, 0.66.0 Jun 4, 2018
@ggazzo ggazzo moved this from Desireable to Ready to merge in June/2018 Jun 14, 2018
@ggazzo ggazzo moved this from Ready to merge to Closed in June/2018 Jun 14, 2018
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

Support the use of IAM instance profile credentials
4 participants