Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admins from LDAP group #1196

Closed
hameno opened this issue Oct 22, 2015 · 9 comments · Fixed by #14278
Closed

Admins from LDAP group #1196

hameno opened this issue Oct 22, 2015 · 9 comments · Fixed by #14278

Comments

@hameno
Copy link

hameno commented Oct 22, 2015

It should be possible to make users that are member of a configured group to be admin, this should prevent #1066

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Megatronic79
Copy link

+1

@JT089
Copy link

JT089 commented Sep 19, 2016

+1 would love that feature too!

@rmdes
Copy link

rmdes commented Nov 2, 2016

would love this feature too !! +1

@fadanner
Copy link

fadanner commented Jan 3, 2017

+1 would be even cooler with the possibility to link ldap groups to global roles, not only for the adminrole

@tonylixu
Copy link

tonylixu commented Nov 5, 2017

would love this feature too !! +1

@mxmo0rhuhn
Copy link

Bountysource
Amazing feature that we would need! Maybe even with support for a more fine grained system

@ghost
Copy link

ghost commented Jan 15, 2019

@engelgabriel I see you've set up a bounty for this, and you're a team member, a head honcho even, but is there a point in applying? I could've done this issue back in '17 when I first noticed it, as I've collected enough LDAP knowledge, but then I got cold feet seeing some 50+ PRs unattended for months. Fast forward a year, and the amount of stale PRs more than doubled. Sooo should I keep RC in mind when I come back in another year?

upd: Next year it is, then. sigh

@wreiske
Copy link
Contributor

wreiske commented Apr 27, 2019

I would like to work on this. I can get started this weekend, I already have some code working that we use internally for our LDAP / AD server.

@engelgabriel are you cool with me starting a pull-request for this? I don't want to start something if there are other pull-requests out there that may affect this. I can get this done over the weekend.

@wreiske
Copy link
Contributor

wreiske commented Apr 28, 2019

Pull request is in. #14278

@Sing-Li Sing-Li added the Triaged label Jul 4, 2019
@engelgabriel engelgabriel added this to the 2.0.0 milestone Aug 28, 2019
Shailesh351 pushed a commit to Shailesh351/Rocket.Chat that referenced this issue Jun 6, 2022
@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.