Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links containing ":" (e.g. LinkedIn links) will render emojis #12321

Closed
peterk opened this issue Oct 11, 2018 · 5 comments · Fixed by #15516
Closed

Links containing ":" (e.g. LinkedIn links) will render emojis #12321

peterk opened this issue Oct 11, 2018 · 5 comments · Fixed by #15516

Comments

@peterk
Copy link

peterk commented Oct 11, 2018

Description:

Pasting links containing the colon character will render an emoji instead of the proper link text. This is problematic for all LinkedIn post links that contains segments with urn:li::

Steps to reproduce:

  1. Paste a LinkedIn post link in any chat in Rocket.chat.
  2. Link segments is converted to emoji.

Expected behavior:

No emojis replaced inside links.

Actual behavior:

image

Server Setup Information:

  • Version of Rocket.Chat Server: 0.68.5
  • Deployment Method: Docker
  • Number of Running Instances: 1

Additional context

Possibly related to #6770

@fcrespo82
Copy link
Contributor

Hi! In the light of #Hacktoberfest I would like to help fix this bug.
Is this already being worked on, or can I help?

@tassoevan
Copy link
Contributor

@fcrespo82 There are some open PRs aiming to fix the entire message rendering system and other ones related to a particular rendering issue, but I think there is not a single one addressing this problem yet.

@c-to-the-l
Copy link

A temporary workaround for this bug is to replace any :s in links with :, which will stop the emoji from being inserted into the link.

Of course, this means hand-editing any messages that have this issue.

@knrt10
Copy link
Contributor

knrt10 commented Mar 2, 2019

On it, will try to fix this.

knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 3, 2019
knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Mar 13, 2019
@ggazzo
Copy link
Member

ggazzo commented Oct 9, 2019

closed by #15516

@ggazzo ggazzo closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants