Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role creation/deletion not working #14090

Closed
geekgonecrazy opened this issue Apr 11, 2019 · 2 comments · Fixed by #14097
Closed

Role creation/deletion not working #14090

geekgonecrazy opened this issue Apr 11, 2019 · 2 comments · Fixed by #14097

Comments

@geekgonecrazy
Copy link
Member

geekgonecrazy commented Apr 11, 2019

Description:

Creation:
image

Deletion:
image

Steps to reproduce:

  1. permissions

  2. create

  3. click save

  4. permissions

  5. click existing role

  6. delete

Expected behavior:

It should actually create the role

Actual behavior:

error.. then nothing

Server Setup Information:

  • Version of Rocket.Chat Server: develop
  • Deployment Method: docker
  • Number of Running Instances: 4
  • DB Replicaset Oplog: true
  • NodeJS Version: docker
  • MongoDB Version: 4.0

Relevant logs:

Creation:

Uncaught TypeError: i is not a function
    at Object.submit #form-role (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:283)
    at 1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87
    at Function.e._withTemplateInstanceFunc (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87)
    at f.View.<anonymous> (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87)
    at 1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87
    at Object.f._withCurrentView (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87)
    at f._DOMRange.<anonymous> (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87)
    at HTMLFormElement.delegatedHandler (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:87)
    at HTMLDivElement.dispatch (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:5)
    at HTMLDivElement.g.handle (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:5)

Deletion:

Exception in delivering result of invoking 'authorization:deleteRole': TypeError: l is not a function
    at 1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:283
    at n._callback (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:1)
    at n._maybeInvokeCallback (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:59)
    at n.receiveResult (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:59)
    at w._livedata_result (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:59)
    at w.onMessage (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:59)
    at currentStatus.connected.forEachCallback.e (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:57)
    at Array.forEach (<anonymous>)
    at l.forEachCallback (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:57)
    at k.socket.onmessage.t [as onmessage] (1eff3ca701b77b4cc63a055c395dc5cd9987de69.js?meteor_js_resource=true:57)
@geekgonecrazy geekgonecrazy changed the title Role creation not working Role creation/deletion not working Apr 11, 2019
@geekgonecrazy
Copy link
Member Author

@ggazzo @tassoevan this is new 0.74.3 this worked

@d-gubert d-gubert added this to the 1.0.0 milestone Apr 11, 2019
@knrt10
Copy link
Contributor

knrt10 commented Apr 11, 2019

@geekgonecrazy the problem is with how t and handleError functions are imported. I have fixed it, making a PR for the same

knrt10 added a commit to knrt10/Rocket.Chat that referenced this issue Apr 11, 2019
rodrigok pushed a commit that referenced this issue Apr 12, 2019
Regression: Role creation and deletion error fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants