Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Role creation and deletion error fixed #14097

Merged
merged 1 commit into from Apr 12, 2019
Merged

Regression: Role creation and deletion error fixed #14097

merged 1 commit into from Apr 12, 2019

Conversation

knrt10
Copy link
Contributor

@knrt10 knrt10 commented Apr 11, 2019

The problem was how t and handleError functions are imported

Closes #14090

cc @geekgonecrazy @tassoevan please review

@wreiske
Copy link
Contributor

wreiske commented Apr 11, 2019

Dang! beat me to it. was going to fix this one today :) Good work.

@MarcosSpessatto MarcosSpessatto added this to the 1.0.0 milestone Apr 11, 2019
@rodrigok rodrigok changed the title [FIX] Role creation and deletion error fixed Regression: Role creation and deletion error fixed Apr 12, 2019
@rodrigok rodrigok merged commit 7b7f455 into RocketChat:develop Apr 12, 2019
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Role creation/deletion not working
4 participants
@knrt10 @wreiske @MarcosSpessatto @rodrigok