Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC Federation not working #18157

Closed
dg-otrs opened this issue Jul 4, 2020 · 5 comments · Fixed by #19009
Closed

IRC Federation not working #18157

dg-otrs opened this issue Jul 4, 2020 · 5 comments · Fixed by #19009

Comments

@dg-otrs
Copy link

dg-otrs commented Jul 4, 2020

Description:

Hey,

the IRC implementation is still not working.

Based on the MERGE with a recommended irc server and config file is also not working:
#10113 (comment)

Steps to reproduce:

  1. In Admin Interface go to IRC Federation
  2. Configure IRC server and Rocket.Chat based on IRC Federation: RFC2813 implementation (ngIRCd) #10113 (comment)

Expected behavior:

IRC Federation with Rocket Chat

Actual behavior:

Server Setup Information:

  • Version of Rocket.Chat Server: 3.3.3
  • Operating System: Gentoo
  • Deployment Method: docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog: Yes
  • NodeJS Version: v12.16.1
  • MongoDB Version: 4.2.8

Additional context

Originally posted by @dg-otrs in #16799 (comment)

Relevant logs:

I20200310-16:28:53.090(0) [irc][server] Connecting to @xxx.com:6667
I20200310-16:28:53.132(0) [irc][server] Connected! Registering as server...
I20200310-16:28:53.133(0) [irc][server] Sending Command: PASS 0210 ngircd
I20200310-16:28:53.133(0) [irc][server] Sending Command: SERVER XXX.com :Rocket.Chat IRC Bridge
I20200310-16:28:53.164(0) [irc][server] Unhandled peer message: {"prefix":"global.rocket.chat","server":"global.rocket.chat","command":"err_needmoreparams","rawCommand":"461","commandType":"error","args":["","PASS","Syntax error"]}
I20200310-16:28:55.167(0) [irc][server] Unhandled peer message: {"prefix":"global.rocket.chat","server":"global.rocket.chat","command":"err_needmoreparams","rawCommand":"461","commandType":"error","args":["","SERVER","Syntax error"]}

@dg-otrs
Copy link
Author

dg-otrs commented Jul 4, 2020

Update on 3.4.1

I20200704-12:36:39.288(0) ➔ +----------------------------------------------+
I20200704-12:36:39.288(0) ➔ | SERVER RUNNING |
I20200704-12:36:39.289(0) ➔ +----------------------------------------------+
I20200704-12:36:39.289(0) ➔ | |
I20200704-12:36:39.290(0) ➔ | Rocket.Chat Version: 3.4.1 |
I20200704-12:36:39.290(0) ➔ | NodeJS Version: 12.16.1 - x64 |
I20200704-12:36:39.291(0) ➔ | MongoDB Version: 4.0.14 |
I20200704-12:36:39.291(0) ➔ | MongoDB Engine: wiredTiger |
I20200704-12:36:39.292(0) ➔ | Platform: linux |
I20200704-12:36:39.292(0) ➔ | Process Port: 3000 |
I20200704-12:36:39.293(0) ➔ | Site URL: http://localhost:3000 |
I20200704-12:36:39.293(0) ➔ | ReplicaSet OpLog: Enabled |
I20200704-12:36:39.294(0) ➔ | Commit Hash: 21157c0 |
I20200704-12:36:39.294(0) ➔ | Commit Branch: HEAD |
I20200704-12:36:39.294(0) ➔ | |
I20200704-12:36:39.295(0) ➔ +----------------------------------------------+
I20200704-12:36:50.560(0) [irc][bridge][queue] Processing "onLogin" command from "local"
I20200704-12:36:50.587(0) [irc][server] Handling local command: registerUser
I20200704-12:36:50.587(0) [irc][server] Sending Command: :irc.rocket.chat NICK admin-rkt 1 admin-rkt irc.rocket.chat 1 +i :otrschatstg
I20200704-12:36:50.597(0) [irc][server] Handling local command: joinedChannel
I20200704-12:36:50.598(0) [irc][server] Sending Command: :admin-rkt JOIN #general
I20200704-12:37:16.387(0) [irc][server] Handling peer message: :modg JOIN #global
I20200704-12:37:16.388(0) [irc][server] Emitting peer command to local: {"identifier":"joinedChannel","args":{"roomName":"global","nick":"modg"}}
I20200704-12:37:16.388(0) [irc][server] Unhandled peer message: {"command":"o","rawCommand":"o","commandType":"normal","args":["o"]}
I20200704-12:37:16.389(0) [irc][bridge][queue] Processing "joinedChannel" command from "peer"
I20200704-12:37:16.421(0) [irc][bridge] ~modg-irc created room global
I20200704-12:37:16.427(0) [irc][bridge][queue] Processing "onCreateRoom" command from "local"
I20200704-12:37:16.435(0) [irc][server] Handling local command: joinChannel
I20200704-12:37:16.436(0) [irc][server] Sending Command: :irc.rocket.chat NJOIN #global :modg
I20200704-12:37:16.437(0) [irc][server] Unhandled peer message: {"prefix":"global.rocket.chat","server":"global.rocket.chat","command":"KILL","rawCommand":"KILL","commandType":"normal","args":["modg","Internal NJOIN error!"]}
I20200704-12:37:16.438(0) [irc][server] Handling peer message: :modg QUIT :Internal NJOIN error!
I20200704-12:37:16.438(0) [irc][server] Emitting peer command to local: {"identifier":"disconnected","args":{"nick":"modg"}}
I20200704-12:37:16.444(0) [irc][bridge][queue] Processing "onCreateRoom" command from "local"
I20200704-12:37:16.449(0) [irc][server] Handling local command: joinChannel
I20200704-12:37:16.449(0) [irc][server] Sending Command: :irc.rocket.chat NJOIN #global :modg
I20200704-12:37:16.454(0) [irc][bridge][queue] Processing "disconnected" command from "peer"
I20200704-12:37:27.951(0) [irc][server] Handling peer message: :global.rocket.chat NICK modg 1 ~modg 10.255.0.2 1 + :modg
I20200704-12:37:27.951(0) [irc][server] Emitting peer command to local: {"identifier":"userRegistered","args":{"nick":"modg","username":"~modg","host":"10.255.0.2","name":"modg"}}
I20200704-12:37:28.952(0) [irc][server] Handling peer message: :modg JOIN #test
I20200704-12:37:28.953(0) [irc][server] Emitting peer command to local: {"identifier":"joinedChannel","args":{"roomName":"test","nick":"modg"}}
I20200704-12:37:28.954(0) [irc][server] Unhandled peer message: {"command":"o","rawCommand":"o","commandType":"normal","args":["o"]}
I20200704-12:37:28.954(0) [irc][server] Handling peer message: :modg JOIN #smalltalk
I20200704-12:37:28.954(0) [irc][server] Emitting peer command to local: {"identifier":"joinedChannel","args":{"roomName":"smalltalk","nick":"modg"}}
I20200704-12:37:28.955(0) [irc][server] Unhandled peer message: {"command":"o","rawCommand":"o","commandType":"normal","args":["o"]}
I20200704-12:37:28.955(0) [irc][server] Handling peer message: :modg JOIN #global
I20200704-12:37:28.956(0) [irc][server] Emitting peer command to local: {"identifier":"joinedChannel","args":{"roomName":"global","nick":"modg"}}
I20200704-12:37:28.956(0) [irc][server] Unhandled peer message: {"command":"o","rawCommand":"o","commandType":"normal","args":["o"]}

@dg-otrs
Copy link
Author

dg-otrs commented Jul 4, 2020

Not sure whats going on but still no messages will be send to irc nor to rocket chat

2020-07-04T12:44:13.751159974Z [1:6 873797] Connection 9 with "10.255.0.2:58118" closed (in: 0.5k, out: 0.4k).
2020-07-04T12:44:13.766677506Z [1:6 873797] Accepted connection 9 from "10.255.0.2:59042" on socket 7.
2020-07-04T12:44:13.773425883Z [62:4 873797] Can't resolve address "10.255.0.2": Name does not resolve [getnameinfo].
2020-07-04T12:44:13.773579441Z [1:6 873797] Peer on connection 9 announces itself as "ngircd" using protocol 2.10 (flags: "").
2020-07-04T12:44:13.773600226Z [1:2 873797] Attention: this server uses a non-standard nick length, but the peer doesn't support the IRC+ extended server handshake!
2020-07-04T12:44:13.773612553Z [1:5 873797] Server "irc.rocket.chat" registered (connection 9, 1 hop - direct link).
2020-07-04T12:44:13.786725801Z [1:6 873797] Synchronization with "irc.rocket.chat" done (connection 9): 0 seconds [1 users, 5 channels].

@dg-otrs
Copy link
Author

dg-otrs commented Jul 4, 2020

Joining and leaving on IRC side will be shown in Rocket Chat, but still now messages!
~modg-irc
14:47
Has left the channel.

~modg-irc
14:47
Has joined the channel.

admin
14:47
test

~modg-irc
14:47
Has left the channel.

~modg-irc
14:47
Has joined the channel.

@dg-otrs
Copy link
Author

dg-otrs commented Jul 4, 2020

Oh yeah its really unstable....

After looking up the IRC user on Rocket Chat Admin -> User (this is the IRC users info under admin https://XX.XX.XX.com/admin/users/info/CcFL6FHMbsTrzQ7Xa) I just see white page... nothing...

After refreshing the browser at above link, I see that the ROCKET CHAT user has logged in to the IRC server successfully:
admin-rkt has joined (admin-rkt@irc.rocket.chat)

Also messaging in this channel is working now.

Sending messages from ROCKET Chat to IRC still not working good, each message will be send 7 times:
admin-rkt has joined (admin-rkt@irc.rocket.chat)
admin-rkt
test
admin-rkt
test
admin-rkt
test
admin-rkt
test
admin-rkt
test
admin-rkt
test
admin-rkt
test

@pierre-lehnen-rc pierre-lehnen-rc self-assigned this Jul 28, 2020
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Sep 26, 2020
@pierre-lehnen-rc pierre-lehnen-rc added feat: irc type: bug and removed stat: stale Stale issues will be automatically closed if no activity labels Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants