Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] IRC Bridge not working #19009

Merged
merged 9 commits into from
Oct 25, 2020
Merged

[FIX] IRC Bridge not working #19009

merged 9 commits into from
Oct 25, 2020

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Sep 24, 2020

Proposed changes

This PR fixes issues that caused the irc bridge to stop working after an IRC user receives a DM;
It also adds support to multiline messages from rocket.chat to IRC.
It also fixes the message loop error that happened when replying to a DM started by an IRC user.

Issue(s)

Closes #18654
Closes #18655
Closes #18157

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@pierre-lehnen-rc pierre-lehnen-rc added this to the 3.8.0 milestone Oct 23, 2020
@sampaiodiego sampaiodiego self-requested a review October 23, 2020 22:13
@sampaiodiego sampaiodiego merged commit aa922cf into develop Oct 25, 2020
@sampaiodiego sampaiodiego deleted the fix.irc-bridge branch October 25, 2020 01:00
@sampaiodiego sampaiodiego mentioned this pull request Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants