Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRC Federation: RFC2813 implementation (ngIRCd) #10113

Merged
merged 47 commits into from
Jun 20, 2018

Conversation

alansikora
Copy link
Contributor

Summary

This is a PR that covers IRC's RFC2813 implementation, using a generic approach, ready for expansion (so we can implement TS6 an others).

How to

Install ngircd and use this very basic ngircd.conf file.

You can also use irssi or any other IRC client to test the other side of the communication.

Limitations

  • all the usernames get -irc and -rkt appended to avoid nick conflict problems;
  • the server needs to accept nicknames longer than 9 chars;

@alansikora alansikora self-assigned this Mar 13, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10113 March 13, 2018 01:09 Inactive
@alansikora alansikora force-pushed the irc-server-federation-rfc2813 branch from 7fee0f4 to b99a5d3 Compare March 13, 2018 01:11
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10113 March 13, 2018 01:12 Inactive
@Hudell
Copy link
Contributor

Hudell commented Jun 7, 2018

Yes

Hudell
Hudell previously approved these changes Jun 7, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10113 June 7, 2018 15:51 Inactive
@evrardjp
Copy link

evrardjp commented Jun 7, 2018

close PR? :D

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10113 June 8, 2018 16:15 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10113 June 8, 2018 16:32 Inactive
@@ -88,6 +88,10 @@ class ModelRooms extends RocketChat.models._Base {

// FIND

findWithUsername(username, options) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodrigok we'll need to rewrite this on no-cache branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@rodrigok rodrigok merged commit 17a63ec into develop Jun 20, 2018
June/2018 automation moved this from Ready to merge to Closed Jun 20, 2018
@rodrigok rodrigok deleted the irc-server-federation-rfc2813 branch June 20, 2018 22:10
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
@miwi-fbsd
Copy link

Hi,

Is there anywhere a documention how that should be setup?

@cutzenfriend
Copy link

Please create a documention on how this works!

@misse
Copy link

misse commented Oct 8, 2018

Hi,

Everything seems to be up and running but I'm not getting irc-channels in my channel list. Can I manually try to join an irc-channel via rocketchat somehow?

Documentation / quickstart would be greatly appreciated.

@Hudell
Copy link
Contributor

Hudell commented Oct 8, 2018

You should see the IRC channels if you click on the search button on Rocket.Chat's sidebar. I'll write a documentation page about using this bridge.

@misse
Copy link

misse commented Nov 16, 2018

Hi @Hudell, do you have any update on this? We're not even getting it to connect and we're having a hard time debugging it.

@jorgeag68
Copy link

jorgeag68 commented Jun 24, 2019

hello.

I can see and join channels from both sides.

But cannot see any messages on either of the sides..

I can messages on the channel if using two IRC users. But nothing passes from rocket.chat to the irc users, and also nothing arrives on the rocket.chat when typed by the irc users.

@dg-otrs
Copy link

dg-otrs commented Mar 9, 2020

Check this comment #216 (comment)

IRC Federation not working with config from #10113 (comment)

@dg-otrs
Copy link

dg-otrs commented May 5, 2020

So yes it can connect but no messages will be transferred via the bridge.... its so sad! as this would be a simple solution to get some better accessibility support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet