Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up arrow should only take you to edit the most recent message in your history. #2153

Closed
bgupta opened this issue Feb 5, 2016 · 13 comments
Closed

Comments

@bgupta
Copy link

bgupta commented Feb 5, 2016

Allowing up and down arrow to move through history indiscriminately, allows one to discard partial edits without any warning. (I've been hit by this so many times as it breaks my expectations, as I am used to the way Skype and Slack handle it, in that up arrow just takes you to your last message, and if you want to go further back you need to select it and click the edit icon.)

@mitar
Copy link
Contributor

mitar commented Mar 10, 2016

+1

@mitar
Copy link
Contributor

mitar commented Mar 10, 2016

Especially once you already start editing a message and you want to go to the beginning of a message and press up it goes to edit a message before.

@mccambridge
Copy link
Contributor

I liked the convenience at first, but then I see the issue: accidentally nuking your edits. Since you can still edit messages via the gear icon, I'm reluctantly a +1 on this.

@adalovebass
Copy link

+1 here as well... I have the annoying habit of moving my cursor down each line as I proofread my edit, meaning I nuke my edits pretty reliably... Sometimes more than once on the same editing attempt!

I would love to see some compromise, though, as I do like the scrolling through all past messages. Maybe once you edit a message, or hit left/right/home/end, it doesn't change the current message anymore; but that's still a bit problematic...

@martinvonwittich
Copy link

I for one absolutely hate the current behavior where up arrow will scroll into sent messages. I often type long messages with multiple line breaks (for example when pasting code) and when I want to scroll to the first line, I'm used to just pressing and holding the up arrow which now causes me to unintentionally end up in some sent message. (I only found out today about Ctrl+Home works).

I'd prefer the behavior that most other clients like Pidgin and Skype have, where Up/Down Arrow only move the cursor in the current message, and Ctrl+Up/Down Arrrow allows to edit sent messages.

@docsncode
Copy link

This is the intended behaviour of editing messages.

@flaviovs
Copy link

Is it possible to disable this feature?

Current UX is not good, as the UI clues that one is editing an already sent message is too subtle, and the mode switch from "post a new message" to "edit an old message" happens without any feedback.

This cause problems when users copy and paste a message to tweak and resend, accidentally press , select the message with the same content, edit, and post, just to find out that they actually edited an old message -- which means nobody gets notified of the "new" message and, worst, original message text is lost forever.

It is happening here all the time. :-(

I understand that this is the intended behaviour, but the discussion here is about changing it, mostly because it is an odd behaviour, different from all other similar chat clients users are accustomed to use, and most importantly it is allowing users to very easily change chat history forever by accident.

To be honest, being a keyboard addict I like the idea of editing previous message using just the keyboard. However, binding the same key to two different purposes ("previous line" and "select previous message") was not a very good choice, IMHO. Perhaps changing to, say, Control+ is the way to go?

@flaviovs
Copy link

Current behaviour, as explained above, use the same keystroke for two different purposes. It is pretty much like having gas and brake on the same pedal in your car. :-)

@seanpackham any chance to consider this change?

@sarrala
Copy link

sarrala commented Mar 4, 2019

@marceloschmidt would it be possible to consider reopening this issue and maybe even taking a second look at it. Maybe this could be resolved through separate configuration option?

Even if this actually is "the intended behaviour of editing messages" maybe you could still make it optional so that editing older messages could only be done through context menu.

Personally I would also like to be able to "clone" last message somehow using arrow keys instead of editing it but that's probably too off topic here.

@adalovebass
Copy link

adalovebass commented Mar 10, 2019 via email

@engelgabriel
Copy link
Member

#14621

@engelgabriel
Copy link
Member

We have updated the behavior so that the arrow up key first navigate to the beginning of the fields first, and only after pressed again it will switch to edit the previews message. We've also saved the text of the input field while you navigate, so you will not lose your message if you switch by mistake, as you just need to move back.

@Anguel
Copy link

Anguel commented Feb 19, 2020

I find the current behavior still very annoying. There must be a way to completely turn off this strange "feature". I have never seen a thing that is so confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests