[FIX] Disabling not supported features in federated channels #27204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/federation-feat-2 #27204 +/- ##
==========================================================
+ Coverage 40.94% 40.98% +0.03%
==========================================================
Files 838 838
Lines 17677 17683 +6
Branches 1983 1985 +2
==========================================================
+ Hits 7238 7247 +9
+ Misses 10201 10194 -7
- Partials 238 242 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
alansikora
approved these changes
Nov 30, 2022
yash-rajpal
requested changes
Jan 6, 2023
yash-rajpal
approved these changes
Jan 10, 2023
MarcosSpessatto
deleted the
fix/federation-fix-channel-visual-elements
branch
gabriellsh
added a commit
that referenced
this pull request
Jan 17, 2023
* feat/federation-search-public-rooms: (21 commits) [FIX] Disabling not supported features in federated channels (#27204) fix: missing files fix: add the auto-join feature back using method call fix: add back the auto join feature after refactoring fix: do not wait to publish it to directory test: adding unit test cases chore: fix lint fix: prefer use rest to avoid collision after merge with other PRs fix: do not show join button on federated rooms if CE fix: do not set room topic if its empty fix: reverting last change + unit tests feat: allow users auto-join user the RC auto-join button fix: fixing bad typing test: fix broken test feat: small tweaks feat: adding support to save federation server names search by user test: adding unit tests for search public rooms feature fix: make it possible with synapse as well (dendrite and synapse behaves different) feat: federation public rooms search (WIP) feat: endpoints to search and join public rooms (WIP) ...
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: (23 commits) fix: change errors strings fix: final tweaks when user join the public room by himself [FIX] Disabling not supported features in federated channels (#27204) fix: missing files fix: add the auto-join feature back using method call fix: add back the auto join feature after refactoring fix: do not wait to publish it to directory test: adding unit test cases chore: fix lint fix: prefer use rest to avoid collision after merge with other PRs fix: do not show join button on federated rooms if CE fix: do not set room topic if its empty fix: reverting last change + unit tests feat: allow users auto-join user the RC auto-join button fix: fixing bad typing test: fix broken test feat: small tweaks feat: adding support to save federation server names search by user test: adding unit tests for search public rooms feature fix: make it possible with synapse as well (dendrite and synapse behaves different) ...
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira: FED-51
@and the matrix syntax are caught by the input.Issue(s)
Steps to test or reproduce
Further comments