[NEW] Matrix federation events coverage expansion + bug fixes #27763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: disabling not supported features on federation channels * fix: fixing display users on autocomplete * fix: small tweaks * fix: disabling OTR in federated rooms * fix: apply suggestions from review * fix review Co-authored-by: yash-rajpal <rajpal.yash03@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #27763 +/- ##
===========================================
+ Coverage 43.71% 43.76% +0.05%
===========================================
Files 790 791 +1
Lines 15258 15392 +134
Branches 2084 2131 +47
===========================================
+ Hits 6670 6737 +67
- Misses 8310 8370 +60
- Partials 278 285 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
* fix: partial message parser for federated rooms fix (WIP) * fix: small fix on edit message to prevent loop * fix: edit quoted messages from RC * fix: fix lint * test: partial fix broken unit tests * fix: small tweaks on parsing messages from RC to Matrix * test: test for message text converter for Matrix flavour * test: add test cases to cover message parser issues
* fix: allow rooms with the same name for different servers (WIP) * fix: display origin server name in room header * fix: small tweaks * fix: generate canonical alias from name when private * fix: use externalRoomId instead of canonical alias * test: adding tests + final tweaks * fix: fix spotlight to support changes with federation * chore: debugging * fix: make it compatible with latest synapse * fix: adding a qa tag * fix: fixing admin rooms list as well * fix: fixing admin rooms edit when federated * fix: final tweaks on room list everywhere * fix: fixing also teh popup channels to support federated rooms * test: fixing federated rooms message popup * fix: disabling federated rooms mentions for now * fix: apply suggestions from review * chore: lint fix
… was not working (#27327) * fix: join the room on proxy server when the invitee is from the proxy server * chore: adding debug * chore: fix lint * chore: trying to debug error on latest synapse version * debug: trying stuff until it works * chore: skip test * chore: trying to confirm race condition diagnosis * fix: trying to fix DM multiple * chore: skipping test for now * chore: making sure every local user auto join the room * fix: removing timeout * fix: trying to fix invites * fix: trying to reapply room state from start * fix: lint * test: skipping * test: debugging * fix: trying to change the callback place * refactor: clean up the code * test: adding unit test cases * fix: add the old event back to the listeners * test: fix broken tests
* chore: adding e2e tests for federation (WIP) * style: fix lint * test: adding basic structure + known tests cases specs * test: adding first test case + configuration * test: adding more tests cases + config tweaks * test: finishing test for public channels * test: tests for private groups * chore: ignoring federation tests * test: tests for DM (WIP) * test: dm tests (WIP) * test: removing useless var * test: removing after each * test: fix lint * test: dm tests tweaks * test: owner rights for channel * test: visual elements for rooms * test: tests from remove users/leave from room * test: ensure the removed from channel sys message shows up in public channels * chore: trying to fix build * refactor: clean up the code a little bit * style: fix lint * refactor: move to another folder * fix: fix paths * fix: addressing this problem in another PR
* chore: adding e2e tests for federation (WIP) * style: fix lint * test: adding basic structure + known tests cases specs * test: adding first test case + configuration * test: adding more tests cases + config tweaks * test: finishing test for public channels * test: tests for private groups * chore: ignoring federation tests * test: tests for DM (WIP) * test: dm tests (WIP) * test: removing useless var * test: removing after each * test: fix lint * test: dm tests tweaks * test: owner rights for channel * test: visual elements for rooms * test: tests from remove users/leave from room * test: ensure the removed from channel sys message shows up in public channels * chore: trying to fix build * refactor: clean up the code a little bit * style: fix lint * refactor: move to another folder * fix: fix paths * test: e2e tests for messaging * test: finishing tests * chore: disable eslint rule for files * test: final tweaks * test: unskip test * fix: addressing this problem in another PR * test: small tweaks * test: more test cases + unskipping some tests * test: several tweaks * chore: fix lint * test: unskip test * test: final tweaks * chore: fix lint * test: small tweaks * test: unskipping tests * test: adding tests cases for CE forbidden actions * test: removing only * test: adapt to the new message composer * test: remove and replace waitForTimeout wherever possible * test: fix stuff from merge
… name per servers (#27578) * chore: adding e2e tests for federation (WIP) * style: fix lint * test: adding basic structure + known tests cases specs * test: adding first test case + configuration * test: adding more tests cases + config tweaks * test: finishing test for public channels * test: tests for private groups * chore: ignoring federation tests * test: tests for DM (WIP) * test: dm tests (WIP) * test: removing useless var * test: removing after each * test: fix lint * test: dm tests tweaks * test: owner rights for channel * test: visual elements for rooms * test: tests from remove users/leave from room * test: ensure the removed from channel sys message shows up in public channels * chore: trying to fix build * refactor: clean up the code a little bit * style: fix lint * refactor: move to another folder * fix: fix paths * test: e2e tests for messaging * test: finishing tests * chore: disable eslint rule for files * test: final tweaks * test: unskip test * fix: addressing this problem in another PR * test: small tweaks * test: more test cases + unskipping some tests * test: several tweaks * chore: fix lint * test: unskip test * test: final tweaks * chore: fix lint * test: small tweaks * test: unskipping tests * test: adding tests cases for CE forbidden actions * test: removing only * test: test to ensure the room with the same names per servers * test: adding more tests cases * test: adding more tests cases * test: adapt to the new message composer * test: remove and replace waitForTimeout wherever possible * test: remove and replace waitForTimeout wherever possible * test: final tweaks * chore: fix lint
* refactor: better structuring folders * feat: endpoints to search and join public rooms (WIP) * feat: federation public rooms search (WIP) * fix: make it possible with synapse as well (dendrite and synapse behaves different) * test: adding unit tests for search public rooms feature * feat: adding support to save federation server names search by user * feat: small tweaks * test: fix broken test * fix: fixing bad typing * feat: allow users auto-join user the RC auto-join button * fix: reverting last change + unit tests * fix: do not set room topic if its empty * fix: do not show join button on federated rooms if CE * fix: prefer use rest to avoid collision after merge with other PRs * chore: fix lint * test: adding unit test cases * fix: do not wait to publish it to directory * fix: add back the auto join feature after refactoring * fix: missing files * fix: add the auto-join feature back using method call * fix: final tweaks when user join the public room by himself * fix: change errors strings * fix: prevent to the user join the room twice * fix: fix wrong condition * test: fix tests broken due to merge * fix: fix wrong stuff from merging * fix: fix wrong stuff from merging(parsing) * fix: final tweaks * fix: final tweaks
* fix: disabling admin actions + do not count only federated and remote users as seat cap * fix: consider as federated users only remote users * chore: fix lint * fix: make sure everything is being validated on BE as well * fix: removing forgotten log * fix: apply suggestions from review * fix: apply suggestions from review (WIP) * fix: apply suggestions from review
* feat: adding the ability to set roles on federated rooms (WIP) * feat: changing room roles logic (WIP) * feat: changing room roles logic (WIP) * refactor: remove all logs * refactor: remove dead code * refactor: small improvements * test: add unit tests(WIP) * test: add more unit tests * refactor: code improvement * fix: change hardcoded error to i18n * test: fix test * fix: DM issue * fix: suggestions from review
….Chat into feat/federation-feat-2
….Chat into feat/federation-feat-2
….Chat into feat/federation-feat-2
dionisio-bot
bot
added
the
stat: ready to merge
pierre-lehnen-rc
previously approved these changes
Feb 15, 2023
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
dionisio-bot
bot
added
stat: ready to merge
hugocostadev
approved these changes
Feb 15, 2023
pierre-lehnen-rc
approved these changes
Feb 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
FED-81
Issue(s)
Steps to test or reproduce
Further comments