[FIX] Marketplace app status initially disabled #27330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a probable fix for the bug in which marketplace apps would, initially, be shown as disabled and then change to installed after a page reload. The bug probably happens because when first installing an app it will have a status of initialized in the apps engine, this initialized status wasnt considered in the app status verification logic which made it show a status of disabled in the UI.
Codecov Report
@@ Coverage Diff @@
## develop #27330 +/- ##
===========================================
+ Coverage 41.31% 42.00% +0.68%
===========================================
Files 841 810 -31
Lines 17706 17130 -576
Branches 1996 1909 -87
===========================================
- Hits 7315 7195 -120
+ Misses 10154 9695 -459
- Partials 237 240 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
juliajforesti
approved these changes
Jan 10, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 16, 2023
…ixSearch * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Show different labels based on the call originator on direct calls (#27729) Chore: Change bundle tags color and refactor app details page header styles (#27293) [FIX] Auto Translate not working on new message template (#27317) Chore: Custom Sounds Empty State (#27632) [IMPROVE] Require acceptance when setting new E2E Encryption key for another user (#27556) Regression: Broken room and message composer events (#27754) [FIX] Missing placeholders from encrypted channel preview messages now with expected behavior (#27699) [IMPROVE] SAML and OAuth role sync to support id and name (#27405) Chore: add e2e test coverage for Video Conference (#27075) Chore: Invites Empty State (#27631) [FIX] Marketplace app status initially disabled (#27330) Regression: Missing contexts on contextual bar (#27734)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Jira task: MKP-20
Currently, the only apps engine statuses considered enabled in the UI are the auto-enabled and manually-enabled statuses, this causes a UX problem in which the app will be considered disabled for the first few seconds of its lifecycle, upon the first installation in a workspace, since it will have the apps engine status of initialized. This PR adds the initialized status to the appEnabledStatuses list and solves this problem.
\
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments