[FIX] Allow federated rooms with the same name per servers #27559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feat/federation-feat-2 #27559 +/- ##
=========================================================
Coverage ? 41.85%
=========================================================
Files ? 845
Lines ? 17817
Branches ? 2024
=========================================================
Hits ? 7457
Misses ? 10092
Partials ? 268
Flags with carried forward coverage won't be shown. Click here to find out more. |
alansikora
approved these changes
Dec 22, 2022
pierre-lehnen-rc
requested changes
Jan 3, 2023
apps/meteor/app/channel-settings/server/functions/saveRoomName.js
Outdated
Show resolved
Hide resolved
hugocostadev
approved these changes
Jan 26, 2023
pierre-lehnen-rc
approved these changes
Jan 30, 2023
gabriellsh
added a commit
that referenced
this pull request
Feb 3, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: fix: fix wrong condition Chore: Federation E2E tests to ensure the room creation with the same name per servers (#27578) Chore: Federation E2E tests for messaging + admin (#27282) Chore: Federation e2e tests for channels (#27115) [FIX] Matrix Federation send message when multiple users are involved was not working (#27327) [FIX] Allow federated rooms with the same name per servers (#27559) [FIX] Support the whole Matrix Markdown spec (#27725)
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The main purpose for this PR is to allow the room creation with the same name, but from different servers, for example:
room1frommatrix.orgroom1frommy-matrix.serverroom1frommy-matrix2.server...
We are still enforcing to have only one room with a specific name per server, for example:
room1frommy-local-server.comroom1frommy-local-server.com<= This is not allowed.Issue(s)
Steps to test or reproduce
Further comments
FED-66