-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Allow federated rooms with the same name per servers #27559
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/federation-feat-2 #27559 +/- ##
=========================================================
Coverage ? 41.85%
=========================================================
Files ? 845
Lines ? 17817
Branches ? 2024
=========================================================
Hits ? 7457
Misses ? 10092
Partials ? 268
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped reviewing when I found a possible bug, will review the rest later.
apps/meteor/app/channel-settings/server/functions/saveRoomName.js
Outdated
Show resolved
Hide resolved
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: fix: fix wrong condition Chore: Federation E2E tests to ensure the room creation with the same name per servers (#27578) Chore: Federation E2E tests for messaging + admin (#27282) Chore: Federation e2e tests for channels (#27115) [FIX] Matrix Federation send message when multiple users are involved was not working (#27327) [FIX] Allow federated rooms with the same name per servers (#27559) [FIX] Support the whole Matrix Markdown spec (#27725)
Proposed changes (including videos or screenshots)
The main purpose for this PR is to allow the room creation with the same name, but from different servers, for example:
room1
frommatrix.org
room1
frommy-matrix.server
room1
frommy-matrix2.server
...
We are still enforcing to have only one room with a specific name per server, for example:
room1
frommy-local-server.com
room1
frommy-local-server.com
<= This is not allowed.Issue(s)
Steps to test or reproduce
Further comments
FED-66