Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom OAuth not working properly #2920

Closed
wtsarchive opened this issue Apr 17, 2016 · 0 comments · Fixed by #2921
Closed

Custom OAuth not working properly #2920

wtsarchive opened this issue Apr 17, 2016 · 0 comments · Fixed by #2921

Comments

@wtsarchive
Copy link
Contributor

wtsarchive commented Apr 17, 2016

Your Rocket.Chat version: 0.26.0

There are two issues with Custom OAuth currently:

  • "Token Sent Via" = "header" doesn't work, it always sends data as payload
  • Reddit expects you to use HTTP Basic Auth when retrieveng access token, but we're not doing so

I made a pull request that fixes those two issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant