New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom OAuth fixes #2921

Merged

engelgabriel merged 2 commits into RocketChat:develop from wtsarchive:custom-oauth-fix

Apr 18, 2016

Contributor

wtsarchive commented Apr 17, 2016 •

edited

Loading

@RocketChat/core

Closes #2920

This pull request does three things in custom OAuth server module:

it fixes a typo that prevented "Token Sent Via" switch from working
it adds HTTP Basic Auth to token retrieval request (so it works with Reddit as per their docs)
it adds a fix for parsing response in registerService method for Reddit

wtsarchive added 2 commits

April 17, 2016 22:28


          Fix typo with @tokenSentVia in Custom OAuth

99656fb


          Make custom OAuth work with Reddit

a92e130

Contributor

lucasvanhalst commented Apr 17, 2016

I guess #2915 can be closed then since this PR also includes that fix

engelgabriel merged commit d8aba3f into RocketChat:develop

didierhk mentioned this pull request

[Snyk] Security upgrade node-gyp from 9.4.1 to 10.0.0 didierhk/Rocket.Chat#382

Open

didierhk mentioned this pull request

[Snyk] Security upgrade node-gyp from 9.4.1 to 10.0.0 didierhk/Rocket.Chat#383

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment