Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automatically convert uploaded avatar to JPEG #3766

Closed
k0nsl opened this issue Jul 13, 2016 · 8 comments · Fixed by #11385
Closed

Don't automatically convert uploaded avatar to JPEG #3766

k0nsl opened this issue Jul 13, 2016 · 8 comments · Fixed by #11385

Comments

@k0nsl
Copy link
Contributor

k0nsl commented Jul 13, 2016

A suggestion: don't automatically convert uploaded avatar to JPEG — this is particularly "annoying" for those who want an animated GIF as their avatar.

@engelgabriel
Copy link
Member

This should be a server setting.

@rodrigok
Copy link
Member

rodrigok commented Jan 4, 2017

We do not support resize of animated gifs.

We can add an setting to define which image types we should resize, then users can remove the gif from the list allowing users to use animated gifs (with no resize)

For other formats it's better to convert to JPEG to reduce the file size.

@rubahness
Copy link

A bunch of white space is added to uploaded GIF avatars; is that part of the conversion to JPEG? It has the result that small animated icons appear even smaller because the converted image + whitespace is scaled back down to avatar height. (not to mention no animation and all the jpeg artifacts) Original av image is 31x30
partyclo-c
rocketchatgifs

@timkinnane
Copy link
Contributor

timkinnane commented Jan 16, 2017

+1. I've made a series of beautiful png avatars with transparency for my bots, but they all inherit an ugly white box for a background when they get converted. :(

@engelgabriel engelgabriel modified the milestones: 0.50.0, Short-term Jan 24, 2017
@9joshua
Copy link

9joshua commented May 27, 2017

+1

This was added to the 0.50.0 milestone but still no animation in 0.56.0. Is this still in the works?

@approximatenumber
Copy link

Converted PNGs looks terrible. Why is there default JPEG conversion instead of PNG?
default

@Bielecki
Copy link

Anything? I made transparent .png avatar, but it converted it with black background.

@engelgabriel
Copy link
Member

We will close this in favor of #11230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants