-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Accept GIFs and SVGs for Avatars converting them to PNG and keep transparency of PNGs #11385
Conversation
@tassoevan what is the difference in size (kb) of the final images? (jpeg x png) @rafaelks is that change (from jpeg to png) ok for mobiles? |
@rodrigok Using |
@rodrigok We're currently requesting the avatars in jpeg format via mobile... will that keep working?
|
@tassoevan @rafaelks I would say we should only change the default background color to white and not allow avatars with transparency |
I guess this was discussed before (#3766), but I see no conclusion about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tassoevan can we verify the upload format and keep the same? So rather than forcing one or the other, we can allow people to decided? PNGs for photos is BAD, and JPG for logos is also really BAD.
I know that the browser can guess the image type from the file itself, but I am not sure how it would work on mobile? Maybe we can send the filetype on the HTTP headers?
What do you guys think?
JPEG & PNG both works in mobile with no problem at all, but we should respect the |
@rafaelks I just changed the format which the avatars are stored. The output still converts from that format to the one requested in |
@tassoevan Great! So nothing should change for the mobile apps since both applications are passing the format parameter. 😊 |
@gabrielsixel do we want to accept avatars with transparent backgrounds? |
@rodrigok wrong Gabriel? |
@gabrielsixel ops, sorry 😄 @engelgabriel do we want to accept avatars with transparent backgrounds? |
Better link #11202 here since there are common decisions to be made. |
Any news on this ? |
Another PR which will never be merged? |
We will work to keep GIFs and PNGs as they are, convert SVGs to PNGs and everything else will be converted to JPG. |
…arency # Conflicts: # packages/rocketchat-file-upload/server/lib/FileUpload.js
Closes #11230
Closes #3766