Video Call Terminated

[graywolf336]

If you have two windows open of the same instance and start a video chat in one you'll get a notification that the person you started it with invited you to a video chat. Declining that invite will end the current video call.

Steps to reproduce:

1. Open two windows of that same chat instance (I used Chrome on Android and Chrome on Windows)
2. Start a call from one to another user, let them accept (I used one opened Android)
3. Look at the other window and see an Invite to Video chat from the person you started the video call with
4. Hit the no button and the current video call ends

Hopefully that's clear, let me know if you have any questions.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Sing-Li]

@graywolf336 - in step 1 - are you opening two windows on the same browser on the same machine? Thx.

[graywolf336]

No, I opened one on Chrome for Windows and then the same location on Chrome for Android.

[Sing-Li]

@graywolf336 - are you saying that you logged on as the same user - on both Windows and Android in Step 1? Thx

[graywolf336]

That is correct

[Sing-Li]

@graywolf336 - so in step 3 ... you are seeing an invite to video from PERSON-A on a session logged in as PERSON-A ?

[graywolf336]

No. Person A starts a video with Person B from one of the windows. Person B accepts and they talk. When Person B accepts, Person A sees an invite in their other window from Person B even though the call is already happening. Person A hits the No button and the ongoing call ends.

[Sing-Li]

@graywolf336 - so in step 3 ... you are seeing an invite to video from PERSON B even though PERSON A was the one who initiated the video call. Correct?

[graywolf336]

Correct

[Sing-Li]

@graywolf336 - thank YOU! That's a bug. The first ever bug publicly reported on Video Chat 👍

[graywolf336]

Glad to help! 😄

[Sing-Li]

😃 @graywolf336 If you don't mind answering one more question.... did you find video chat to be stable --> connects 80% + of the time. Or are your connections hit-and-miss? thanks again.

[graywolf336]

When they would connect, it was very stable on WiFi. But sadly towards the end, them connecting was hit-and-miss.

[geekgonecrazy]

It looked like it was mainly an issue with the other person not getting alerted of the video request.

Almost like the webrtc stuff was setup and the other side was never told about it.

But like @graywolf336 said once connected it was awesome.

[Sing-Li]

Thanks @graywolf336 and @geekgonecrazy. The QoS feedback is very valuable.

[Megatronic79]

Not sure of this belongs here but when trying the video calling feature the remote user never gets the video request - tried from different browsers and the rocket.chat windows client.. any logs we can view to see the connection \ request attempt?

[Sing-Li]

@Megatronic79 --- please follow the instructions at the end of this to 'switch in' the rocketchat:webrtc-ib signaling stack:

https://github.com/RocketChat/Rocket.Chat/wiki/Using-Face-to-face-video-conference-(aka-webrtc)

-- and let us know if the problem goes away for you. Thanks.

[Megatronic79]

Thanks @Sing-Li that now works with mozilla.

Tested with the Windows Client (0.0.7) and it doesnt work yet even after that change, will this be implemented in a later build?

[Sing-Li]

@Megatronic79 - WebRTC is a browser standard.

Even though our desktop and mobile apps often embed browser technologies, WebRTC compatibility is seldom a concern/feature for the underlying framework. It is impossible to ensure compatibility.

So, no, not likely.

Use the latest Chrome or Firefox on Windows if WebRTC is core to your use case - they have been both thoroughly tested to work (even with one-another!).

[Sing-Li]

@graywolf336 - just an update for you. This bug has been reproduced, confirmed, and a fix crafted. Just pending some time to thoroughly test it.

[graywolf336]

@Sing-Li awesome, thanks!

[gmsecrieru]

There are so many changes on WebRTC about to be merged into master from #989 that this might be addressed as well. Would you try again with latest code @graywolf336 ?

[graywolf336]

Sure will!
On Oct 4, 2015 1:02 PM, "George Secrieru" notifications@github.com wrote:

There are so many changes on WebRTC about to merged into master from #989
#989 that this might be
addressed as well. Would you try again with latest code @graywolf336
https://github.com/graywolf336 ?

—
Reply to this email directly or view it on GitHub
#521 (comment)
.

[graywolf336]

@gmsecrieru Yes it is still happening. I started a video chat with someone on my phone and it came up on my desktop with "Direct video call from my.username".

[engelgabriel]

To be done as part of #933

[MartinSchoeler]

@graywolf336 can we close this?