[FIX] Initial loading feedback was missing #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Mar 6, 2018
| @@ -71,8 +71,7 @@ RocketChat.settings.get('Assets_SvgFavicon_Enable', (key, value) => { | |||
| }); | |||
|
|
|||
| RocketChat.settings.get('theme-color-sidebar-background', (key, value) => { | |||
| Inject.rawHead(key, `<style>body { background-color: ${ value };}</style>` + | |||
There was a problem hiding this comment.
any reason removing it from here and adding it to "external" CSS? the idea was just this, not need to wait for the whole CSS to apply the initial background color
There was a problem hiding this comment.
When you load the app the css is up already, but I forgot that you can change this color... in that case the app will load the default color. I'll fix that.
There was a problem hiding this comment.
the first time you enter on a server, his css is not up already 😉
There was a problem hiding this comment.
I was wrong on my comment. @ggazzo made a dynamic css loader script that runs before that, so it will work with the colors that the user set on DB.
sampaiodiego
approved these changes
Mar 6, 2018
rodrigok
changed the title
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core