[FIX] Add '.value' in the SAML package to fix TypeErrors on SAML token validation #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
heysanil
changed the title
heysanil
changed the title
jahantech
approved these changes
Mar 14, 2018
gutmox
approved these changes
Mar 14, 2018
|
I would suggest to test the latest version of the https://github.com/steffow/meteor-accounts-saml (I replaced the XML parsing code) and if it still fails, do a pull request there to prevent upstream issues |
|
Any news on this fix? I have worked with OneLogin to develop a SAML app for RocketChat, but can't confirm it is working correctly with these errors. We are waiting to deploy. |
|
Guys, I did some changes, can you test and see if it is still working? |
|
Happy to test, but I deploy via Docker. How long does it usually take for the updated dev image to get published on Docker Hub? |
sampaiodiego
approved these changes
Apr 5, 2018
|
I believe the lines 399 and 401 of the saml_utils.js file should also receive a .value, when accessing attributes' names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #10056
SAML broke with 0.62.1 and throws a TypeError while validating a token from the IdP. As observed by @chrosey in #10056, adding '.value' in two locations of the SAML package fixes the issue.