[FIX] Add user object to responses in /*.files Rest endpoints #10480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hudell
previously approved these changes
Apr 20, 2018
Hudell
reviewed
Apr 20, 2018
| RocketChat.API.helperMethods.set('replaceUserIdKeyByUserObject', function _addUserToObject({ object, userId }) { | ||
| const { username, name } = RocketChat.models.Users.findOneById(userId); | ||
| if (object.hasOwnProperty('userId')) { | ||
| delete object.userId; |
There was a problem hiding this comment.
I'm not sure if removing the userId is a good idea, as it may break something that relies on it, but I tested the application and didn't find any problem.
rodrigok
force-pushed
the
fix-rest-files
branch
from
f41cf6b
to
862b27a
Compare
rodrigok
force-pushed
the
fix-rest-files
branch
from
862b27a
to
082473d
Compare
rodrigok
approved these changes
Apr 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user object to responses in /[groups, channels, im].files Rest endpoints.
Closes #10449.