[FIX] Missing "Administration" menu for users with some administration permissions #10551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- manage-integrations - manage-oauth-apps - manage-own-integrations - manage-sounds - view-logs - view-statistics
sampaiodiego
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
thx @kaiiiiiiiii .. although this is not the right solution, it is better than what we have now.
the ideal solution would be removing hardcoded menus and adding them using RocketChat.AdminBox.addOption , then to check if the three dots should be shown we should "ask" to RocketChat.AdminBox if the user has some permission.
sampaiodiego
changed the title
|
I’ll have a look @sampaiodiego and submit a new PR next week when I have a bit of spare time :) |
Merged
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
May 2, 2018
* develop: Regression: Various search provider fixes (RocketChat#10591) Fix /api/v1/settings.oauth not sending needed info for SAML & CAS (RocketChat#10596) Fix the Apps and Livechats not getting along well with each other (RocketChat#10598) [FIX] Missing "Administration" menu for users with some administration permissions (RocketChat#10551) [FIX] Member list search with no results (RocketChat#10599) Adds Visual Studio Code debugging configuration (RocketChat#10586) [FIX] Integrations with room data not having the usernames filled in (RocketChat#10576)
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
May 2, 2018
* goalify: (104 commits) Regression: Various search provider fixes (RocketChat#10591) Supplement TOS and privacy policy texts for use within server instances Fix /api/v1/settings.oauth not sending needed info for SAML & CAS (RocketChat#10596) Fix the Apps and Livechats not getting along well with each other (RocketChat#10598) [FIX] Missing "Administration" menu for users with some administration permissions (RocketChat#10551) [FIX] Member list search with no results (RocketChat#10599) merge vi-VN and vi json Add and enhance translations Update gitlab, npm package lock, include current server update script Adds Visual Studio Code debugging configuration (RocketChat#10586) [FIX] Integrations with room data not having the usernames filled in (RocketChat#10576) fixed problems with margin negative (RocketChat#10558) Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574) Added target="_blank" to homepage and support link. (RocketChat#10575) [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503) [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550) Fix inconsistent response of settings.oauth endpoint (RocketChat#10553) Regression: Remove added mentions on quote/reply (RocketChat#10571) Fix the attachments and fields incorrectly failing on validation (RocketChat#10573) Deps update (RocketChat#10549) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #10171 and closes #10226
Description
The following permissions need to enable the three dots admin menu as well: