Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Switch buttons were cutting in RTL mode #10558

Merged
merged 2 commits into from
Apr 26, 2018
Merged

[FIX] Switch buttons were cutting in RTL mode #10558

merged 2 commits into from
Apr 26, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 23, 2018

Closes #9382

@ggazzo ggazzo added this to the 0.65.0 milestone Apr 23, 2018
@ggazzo ggazzo added this to Desirable in May/2018 via automation Apr 23, 2018
@ggazzo ggazzo moved this from Desirable to Review/QA in May/2018 Apr 23, 2018
@sampaiodiego sampaiodiego added this to Desireable in 0.64.0 via automation Apr 24, 2018
@sampaiodiego sampaiodiego modified the milestones: 0.65.0, 0.64.0 Apr 24, 2018
@sampaiodiego sampaiodiego removed this from Review/QA in May/2018 Apr 24, 2018
@ggazzo ggazzo changed the title [FIX] fixed problems with margin negative [FIX] fixed switch component problems with margin negative Apr 25, 2018
@theorenck theorenck moved this from Desireable to Review/QA in 0.64.0 Apr 25, 2018
@rodrigok rodrigok changed the title [FIX] fixed switch component problems with margin negative [FIX] Switch buttons were cutting in RTL mode Apr 26, 2018
@rodrigok rodrigok merged commit aeda3b3 into develop Apr 26, 2018
0.64.0 automation moved this from Review/QA to Done Apr 26, 2018
@rodrigok rodrigok deleted the create-channel-hidden-problems branch April 26, 2018 03:32
trongthanh added a commit to goalifyplus/Goalify.Chat that referenced this pull request Apr 27, 2018
@trongthanh
Merge branch 'develop' into goalify
cbbaba3 
* develop: (79 commits)
  fixed problems with margin negative (RocketChat#10558)
  Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574)
  Added target="_blank" to homepage and support link. (RocketChat#10575)
  [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503)
  [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550)
  Fix inconsistent response of settings.oauth endpoint (RocketChat#10553)
  Regression: Remove added mentions on quote/reply (RocketChat#10571)
  Fix the attachments and fields incorrectly failing on validation (RocketChat#10573)
  Deps update (RocketChat#10549)
  Map consumerKey to clientId (fix Twitter) (RocketChat#10560)
  Regression: Webhooks breaking duo to a too restrict test (RocketChat#10555)
  Fix issues with the rooms and apps (RocketChat#10559)
  Fix regression with announcement bar being displayed without content (RocketChat#10554)
  LingoHub based on develop (RocketChat#10545)
  Regression: Revert announcement structure (RocketChat#10544)
  Regression: Upload was not working (RocketChat#10543)
  Remove duplicated key from en.i18n.json
  Included missing lib (RocketChat#10532)
  dependencies update
  [NEW] Option to mute group mentions (@ALL and @here) (RocketChat#10502)
  ...

# Conflicts:
#	packages/rocketchat-i18n/i18n/en.i18n.json
#	packages/rocketchat-i18n/i18n/vi-VN.i18n.json
#	packages/rocketchat-ui-flextab/client/tabs/membersList.html
#	packages/rocketchat-ui-message/client/popup/messagePopupConfig.js
#	packages/rocketchat-ui-sidenav/client/sidebarHeader.js
nguyendichtu91295 added a commit to goalifyplus/Goalify.Chat that referenced this pull request Apr 27, 2018
@nguyendichtu91295
Merge branch 'goalify' of https://github.com/goalifyplus/Goalify.Chat …
cf3d080 
…into goalify

* 'goalify' of https://github.com/goalifyplus/Goalify.Chat: (80 commits)
  Update gitlab, npm package lock, include current server update script
  fixed problems with margin negative (RocketChat#10558)
  Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574)
  Added target="_blank" to homepage and support link. (RocketChat#10575)
  [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503)
  [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550)
  Fix inconsistent response of settings.oauth endpoint (RocketChat#10553)
  Regression: Remove added mentions on quote/reply (RocketChat#10571)
  Fix the attachments and fields incorrectly failing on validation (RocketChat#10573)
  Deps update (RocketChat#10549)
  Map consumerKey to clientId (fix Twitter) (RocketChat#10560)
  Regression: Webhooks breaking duo to a too restrict test (RocketChat#10555)
  Fix issues with the rooms and apps (RocketChat#10559)
  Fix regression with announcement bar being displayed without content (RocketChat#10554)
  LingoHub based on develop (RocketChat#10545)
  Regression: Revert announcement structure (RocketChat#10544)
  Regression: Upload was not working (RocketChat#10543)
  Remove duplicated key from en.i18n.json
  Included missing lib (RocketChat#10532)
  dependencies update
  ...
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Merged
trongthanh added a commit to goalifyplus/Goalify.Chat that referenced this pull request May 2, 2018
@trongthanh
Merge branch 'goalify'
4aa31f3 
* goalify: (104 commits)
  Regression: Various search provider fixes (RocketChat#10591)
  Supplement TOS and privacy policy texts for use within server instances
  Fix /api/v1/settings.oauth not sending needed info for SAML & CAS (RocketChat#10596)
  Fix the Apps and Livechats not getting along well with each other (RocketChat#10598)
  [FIX] Missing "Administration" menu for users with some administration permissions (RocketChat#10551)
  [FIX] Member list search with no results (RocketChat#10599)
  merge vi-VN and vi json
  Add and enhance translations
  Update gitlab, npm package lock, include current server update script
  Adds Visual Studio Code debugging configuration (RocketChat#10586)
  [FIX] Integrations with room data not having the usernames filled in (RocketChat#10576)
  fixed problems with margin negative (RocketChat#10558)
  Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574)
  Added target="_blank" to homepage and support link. (RocketChat#10575)
  [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503)
  [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550)
  Fix inconsistent response of settings.oauth endpoint (RocketChat#10553)
  Regression: Remove added mentions on quote/reply (RocketChat#10571)
  Fix the attachments and fields incorrectly failing on validation (RocketChat#10573)
  Deps update (RocketChat#10549)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

Assignees
No one assigned
Labels
type: release candidate bug
Projects
No open projects
0.64.0
  
Done
Milestone
0.64.0
Development

Successfully merging this pull request may close these issues.

[BUG] [UI] [RTL] Create channel radio button align breaks
4 participants
@ggazzo @karlprieb @rodrigok @sampaiodiego