Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] UI was not disabling the actions when users has had no permissions to create channels or add users to rooms #10564

Merged
merged 18 commits into from
May 18, 2018
Merged

[FIX] UI was not disabling the actions when users has had no permissions to create channels or add users to rooms #10564

merged 18 commits into from
May 18, 2018

Commits on Apr 23, 2018

  1. hide plus icon when user doesn't have both permission for create-c an… 

    …d create-p
    @cfunkles
    cfunkles committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    f592669 View commit details
    Browse the repository at this point in the history

  2. add helper to checkout two permissions set initial value for the room… 

    … type
    @cfunkles
    cfunkles committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    df6e91b View commit details
    Browse the repository at this point in the history

  3. hide the plus icon in directory if user doesn't have both create-c an… 

    …d creat-p permissions
    @cfunkles
    cfunkles committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    badaefe View commit details
    Browse the repository at this point in the history

  4. get permissions for create channels and groups

    @cfunkles
    cfunkles committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    bda88ac View commit details
    Browse the repository at this point in the history

  5. check if user can add channel hide and groups, hide button based upon… 

    … correct state
    @cfunkles
    cfunkles committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    9e49bc9 View commit details
    Browse the repository at this point in the history

  6. prevent add user button from being hidden when user has permission ad… 

    …d user to joined room
    @cfunkles
    cfunkles committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    dcdb454 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2018

  1. Merge branch 'develop' into fix-permissions-bug-create-channels-add-u… 

    …sers
    @chuckAtCataworx
    chuckAtCataworx committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    87999b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix-permissions-bug-create-channels-add-u… 

    …sers
    @chuckAtCataworx
    chuckAtCataworx committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    f2232ae View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. removed the if statement and use short hand if else syntax

    @cfunkles
    cfunkles committed May 11, 2018
    Configuration menu
    Copy the full SHA
    7e5a44f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into fix-permissions-bug-create-channels-add-u… 

    …sers
    @chuckAtCataworx
    chuckAtCataworx committed May 11, 2018
    Configuration menu
    Copy the full SHA
    74a8d87 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix-permissions-bug-create-channels-add-users' of https… 

    …://github.com/chuckAtCataworx/Rocket.Chat into fix-permissions-bug-create-channels-add-users
    @cfunkles
    cfunkles committed May 11, 2018
    Configuration menu
    Copy the full SHA
    31e6e5b View commit details
    Browse the repository at this point in the history

  4. better code for disabling checkbox in create room feature if user doe… 

    …sn't have permission
    @cfunkles
    cfunkles committed May 11, 2018
    Configuration menu
    Copy the full SHA
    8853fb8 View commit details
    Browse the repository at this point in the history

  5. add missing simicolon

    @cfunkles
    cfunkles committed May 11, 2018
    Configuration menu
    Copy the full SHA
    aee7a94 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. put canShowAddUsersButton into seperate function call function in eve… 

    …nts and helpers
    @cfunkles
    cfunkles committed May 15, 2018
    Configuration menu
    Copy the full SHA
    975ef05 View commit details
    Browse the repository at this point in the history

  2. move the canShowAddUsersButton function to define before it's called

    @cfunkles
    cfunkles committed May 15, 2018
    Configuration menu
    Copy the full SHA
    807b25e View commit details
    Browse the repository at this point in the history

Commits on May 16, 2018

  1. Merge branch 'develop' into fix-permissions-bug-create-channels-add-u… 

    …sers
    @chuckAtCataworx
    chuckAtCataworx committed May 16, 2018
    Configuration menu
    Copy the full SHA
    ae193fa View commit details
    Browse the repository at this point in the history

  2. fix bug that prevents the viewing of the keyboard shortcuts button in… 

    … groups and direct messages
    @cfunkles
    cfunkles committed May 16, 2018
    Configuration menu
    Copy the full SHA
    44cda3a View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. fix permissions

    @ggazzo
    ggazzo committed May 18, 2018
    Configuration menu
    Copy the full SHA
    c9ad6ec View commit details
    Browse the repository at this point in the history