[FIX] Cannot read property 'debug' of undefined when trying to use REST API

[haffla]

Fixes #10581 (I don't know why it was closed)

I am not sure why logger was defined twice - once as an instance outside of the class and once as a field of the class using this. This PR cleans this up a little by removing the latter. I believe it is obvious why this.logger is undefined since it is called inside of function _internalRouteActionHandler() { ... } which creates a new scope where this is something else.

To be honest - and I am very sorry for that - I did not test this but I tried for two hours to get Rocket.Chat running on my machine to no avail (and I am no JS noob), neither the develop branch nor any of the recent releases, different errors all over the place. I followed the developer section in the Readme.

Also the test suit npm run test doesn't work, so I am really sorry for that.

What I don't understand is why this has not been crashing for everyone?!?!

Edit: I was able to test this now 👍

[CLAassistant]

All committers have signed the CLA.

[haffla]

Updating to latest seems to fix the problem. Feel free to close this. Though I think this PR still has a point.

EDIT: Nope, it's crashing again... this seems to be very non-deterministic, nasty bug

[rodrigok]

Hi @haffla we just found a race condition where the api endpoint is registered before the declaration of this.logger at the constructor, that cause the issue.

Your PR solves that issue, we will merge it and complement with another fix.

Thanks