Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Confirm password on set new password user profile #11095

Merged
merged 4 commits into from
Jun 12, 2018

Conversation

tassoevan
Copy link
Contributor

Related to #10730

@tassoevan tassoevan requested a review from ggazzo June 11, 2018 19:40
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11095 June 11, 2018 19:40 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11095 June 11, 2018 19:41 Inactive
Copy link
Member

@engelgabriel engelgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please changes the PR #9969 to make sure we are using the same translation keys and remove the setting they have created for the placeholder using a migration

@ggazzo ggazzo dismissed engelgabriel’s stale review June 12, 2018 15:59

;) both are right

@tassoevan tassoevan added this to Review/QA in June/2018 via automation Jun 12, 2018
@tassoevan tassoevan self-assigned this Jun 12, 2018
@tassoevan tassoevan added this to the 0.66.0 milestone Jun 12, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11095 June 12, 2018 19:53 Inactive
@ggazzo ggazzo changed the title [FIX] Input for confirmation of new password on edit account profile [FIX] Confirm password on set new password user profile Jun 12, 2018
@ggazzo ggazzo merged commit a18fe25 into develop Jun 12, 2018
June/2018 automation moved this from Review/QA to Closed Jun 12, 2018
@ggazzo ggazzo deleted the confirm-new-password-on-edit-account branch June 12, 2018 21:03
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
June/2018
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants