Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Custom sound uploader not working in Firefox and IE #11139

Merged

Conversation

vynmera
Copy link
Contributor

@vynmera vynmera commented Jun 13, 2018

Closes #8460
Actually closes #6200

A fix that was made before only fixed half of the issue, sadly.
Now it is fully fixed and happy, and you can silently change your coworker's notification sound to the loudest version of the Monopoly theme you can find on the internet, all from Firefox.

Oh yeah, Firefox wasn't showing the file picker properly either, it let you select non-mp3 files. So that's fixed too, in case you find yourself confusing .mp3 and .png far too often. :-)

Before:
2018-06-13_22-53-56

After:
2018-06-13_22-53-42

@vynmera vynmera changed the title [FIX] Custom sound upload complaining in every browser other than Chrome [FIX] Custom sound uploader not working in Firefox and IE Jun 15, 2018
@engelgabriel engelgabriel added this to the 0.69.0 milestone Aug 13, 2018
@engelgabriel engelgabriel merged commit 6a52f62 into RocketChat:develop Aug 13, 2018
@sampaiodiego sampaiodiego mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom sound: says wrong file format but is mp3 Custom Sounds cannot be uploaded from Firefox or IE
2 participants