[FIX] REST users.setAvatar endpoint wasn't allowing update the avatar of other users even with correct permissions
#11431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nother user even with necessary permission
rodrigok
changed the title
users.setAvatar endpoint wasn't allowing update the avatar of other users even with correct permissions
rodrigok
reviewed
Aug 20, 2018
| userFromFormData = RocketChat.models.Users.findOneByUsername(fields.username); | ||
| } | ||
| return userFromFormData; | ||
| }; |
There was a problem hiding this comment.
Suggestion:
const getUserFromFormData = (fields) => {
if (fields.userId) {
return RocketChat.models.Users.findOneById(fields.userId, {_id: 1});
}
if (fields.username) {
return RocketChat.models.Users.findOneByUsername(fields.username, {_id: 1});
}
};| })); | ||
| busboy.on('field', (fieldname, val) => { | ||
| fields = Object.assign(fields, { [fieldname]: val }); | ||
| }); |
There was a problem hiding this comment.
Why not?:
busboy.on('field', (fieldname, val) => {
fields[fieldname] = val;
});| const imageData = []; | ||
| file.on('data', Meteor.bindEnvironment((data) => { | ||
| imageData.push(data); | ||
| })); | ||
|
|
||
| file.on('end', Meteor.bindEnvironment(() => { | ||
| const sentTheUserByFormData = fields.userId || fields.username; | ||
| if (sentTheUserByFormData) { | ||
| user = getUserFromFormData(fields); |
There was a problem hiding this comment.
Where are we checking the permissions to change the other user's avatar?
|
Any updates on this, why is it on hold? |
sampaiodiego
approved these changes
Oct 20, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11334