Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Setup wizard calling 'saveSetting' for each field/setting #13349

Merged
merged 1 commit into from
Feb 5, 2019
Merged

[FIX] Setup wizard calling 'saveSetting' for each field/setting #13349

merged 1 commit into from
Feb 5, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 4, 2019 •
edited by tassoevan
Loading

the old method was calling multiple times saveSetting, now we have one saveSettings, that you can pass all settings in a row.

Closes #13329

@ggazzo ggazzo requested a review from rodrigok February 4, 2019 22:16
@ggazzo ggazzo changed the title [FIX] Settings. batchSet [FIX] Settings.batchSet Feb 4, 2019
@rodrigok rodrigok added this to the 0.74.2 milestone Feb 5, 2019
@rodrigok rodrigok changed the title [FIX] Settings.batchSet [FIX] Settings saving was being called multiple times and being denied by Rate Limiter in some cases Feb 5, 2019
@rodrigok rodrigok merged commit 5297f3d into develop Feb 5, 2019
@rodrigok rodrigok deleted the fix-batch branch February 5, 2019 16:12
@ggazzo ggazzo changed the title [FIX] Settings saving was being called multiple times and being denied by Rate Limiter in some cases [FIX] Settings saving were being called multiple times and being denied by Rate Limiter in some cases Feb 5, 2019
@ggazzo ggazzo changed the title [FIX] Settings saving were being called multiple times and being denied by Rate Limiter in some cases [FIX] Setup wizard calling 'saveSetting' for each one Feb 5, 2019
@ggazzo ggazzo changed the title [FIX] Setup wizard calling 'saveSetting' for each one [FIX] Setup wizard calling 'saveSetting' for each field/setting Feb 5, 2019
sampaiodiego pushed a commit that referenced this pull request Feb 5, 2019
@ggazzo @sampaiodiego
fix batchSet settings (#13349)
ef88185
@sampaiodiego sampaiodiego mentioned this pull request Feb 5, 2019
Merged
Montel pushed a commit to Montel/Rocket.Chat that referenced this pull request Feb 13, 2019
@ggazzo @Montel
fix batchSet settings (RocketChat#13349)
0b3914e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.74.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @rodrigok @engelgabriel